Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: Source/core/fileapi/FileReader.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fileapi/File.h ('k') | Source/core/fileapi/FileReaderLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fileapi/FileReader.h
diff --git a/Source/core/fileapi/FileReader.h b/Source/core/fileapi/FileReader.h
index 7e81ee2207a1a8ed62f0f245df83bac6ebc7e198..0506748ab826d2301140ce97ba95ab53753e36dc 100644
--- a/Source/core/fileapi/FileReader.h
+++ b/Source/core/fileapi/FileReader.h
@@ -56,7 +56,7 @@ class CORE_EXPORT FileReader final : public RefCountedGarbageCollectedEventTarge
public:
static FileReader* create(ExecutionContext*);
- virtual ~FileReader();
+ ~FileReader() override;
enum ReadyState {
EMPTY = 0,
@@ -78,18 +78,18 @@ public:
void result(StringOrArrayBuffer& resultAttribute) const;
// ActiveDOMObject
- virtual void stop() override;
- virtual bool hasPendingActivity() const override;
+ void stop() override;
+ bool hasPendingActivity() const override;
// EventTarget
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
// FileReaderLoaderClient
- virtual void didStartLoading() override;
- virtual void didReceiveData() override;
- virtual void didFinishLoading() override;
- virtual void didFail(FileError::ErrorCode) override;
+ void didStartLoading() override;
+ void didReceiveData() override;
+ void didFinishLoading() override;
+ void didFail(FileError::ErrorCode) override;
DEFINE_ATTRIBUTE_EVENT_LISTENER(loadstart);
DEFINE_ATTRIBUTE_EVENT_LISTENER(progress);
« no previous file with comments | « Source/core/fileapi/File.h ('k') | Source/core/fileapi/FileReaderLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698