Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/inspector/InspectorDOMAgent.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.h ('k') | Source/core/inspector/InspectorDOMAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMAgent.h
diff --git a/Source/core/inspector/InspectorDOMAgent.h b/Source/core/inspector/InspectorDOMAgent.h
index 5c41487ae9c4f6e39cc35b413e582354d4ef6487..ecc4ab2a8eb06cb41d85040469c1eeeda46f885e 100644
--- a/Source/core/inspector/InspectorDOMAgent.h
+++ b/Source/core/inspector/InspectorDOMAgent.h
@@ -95,7 +95,7 @@ public:
static String toErrorString(ExceptionState&);
static bool getPseudoElementType(PseudoId, TypeBuilder::DOM::PseudoType::Enum*);
- virtual ~InspectorDOMAgent();
+ ~InspectorDOMAgent() override;
DECLARE_VIRTUAL_TRACE();
void disable(ErrorString*) override;
@@ -105,46 +105,46 @@ public:
void reset();
// Methods called from the frontend for DOM nodes inspection.
- virtual void enable(ErrorString*) override;
- virtual void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId) override;
- virtual void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<TypeBuilder::Array<int> >& result) override;
- virtual void getDocument(ErrorString*, RefPtr<TypeBuilder::DOM::Node>& root) override;
- virtual void requestChildNodes(ErrorString*, int nodeId, const int* depth) override;
- virtual void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value) override;
- virtual void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name) override;
- virtual void removeAttribute(ErrorString*, int elementId, const String& name) override;
- virtual void removeNode(ErrorString*, int nodeId) override;
- virtual void setNodeName(ErrorString*, int nodeId, const String& name, int* newId) override;
- virtual void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML) override;
- virtual void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML) override;
- virtual void setNodeValue(ErrorString*, int nodeId, const String& value) override;
- virtual void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const bool* includeUserAgentShadowDOM, String* searchId, int* resultCount) override;
- virtual void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<TypeBuilder::Array<int> >&) override;
- virtual void discardSearchResults(ErrorString*, const String& searchId) override;
- virtual void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<TypeBuilder::Runtime::RemoteObject>& result) override;
- virtual void getAttributes(ErrorString*, int nodeId, RefPtr<TypeBuilder::Array<String> >& result) override;
- virtual void setInspectModeEnabled(ErrorString*, bool enabled, const bool* inspectUAShadowDOM, const RefPtr<JSONObject>* highlightConfig) override;
- virtual void requestNode(ErrorString*, const String& objectId, int* nodeId) override;
- virtual void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId) override;
- virtual void pushNodesByBackendIdsToFrontend(ErrorString*, const RefPtr<JSONArray>& nodeIds, RefPtr<TypeBuilder::Array<int> >&) override;
- virtual void setInspectedNode(ErrorString*, int nodeId) override;
- virtual void hideHighlight(ErrorString*) override;
- virtual void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) override;
- virtual void highlightQuad(ErrorString*, const RefPtr<JSONArray>& quad, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) override;
- virtual void highlightNode(ErrorString*, const RefPtr<JSONObject>& highlightConfig, const int* nodeId, const int* backendNodeId, const String* objectId) override;
- virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) override;
-
- virtual void copyTo(ErrorString*, int nodeId, int targetElementId, const int* anchorNodeId, int* newNodeId) override;
- virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId) override;
- virtual void undo(ErrorString*) override;
- virtual void redo(ErrorString*) override;
- virtual void markUndoableState(ErrorString*) override;
- virtual void focus(ErrorString*, int nodeId) override;
- virtual void setFileInputFiles(ErrorString*, int nodeId, const RefPtr<JSONArray>& files) override;
- virtual void getBoxModel(ErrorString*, int nodeId, RefPtr<TypeBuilder::DOM::BoxModel>&) override;
- virtual void getNodeForLocation(ErrorString*, int x, int y, int* nodeId) override;
- virtual void getRelayoutBoundary(ErrorString*, int nodeId, int* relayoutBoundaryNodeId) override;
- virtual void getHighlightObjectForTest(ErrorString*, int nodeId, RefPtr<JSONObject>&) override;
+ void enable(ErrorString*) override;
+ void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId) override;
+ void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<TypeBuilder::Array<int>>& result) override;
+ void getDocument(ErrorString*, RefPtr<TypeBuilder::DOM::Node>& root) override;
+ void requestChildNodes(ErrorString*, int nodeId, const int* depth) override;
+ void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value) override;
+ void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name) override;
+ void removeAttribute(ErrorString*, int elementId, const String& name) override;
+ void removeNode(ErrorString*, int nodeId) override;
+ void setNodeName(ErrorString*, int nodeId, const String& name, int* newId) override;
+ void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML) override;
+ void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML) override;
+ void setNodeValue(ErrorString*, int nodeId, const String& value) override;
+ void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const bool* includeUserAgentShadowDOM, String* searchId, int* resultCount) override;
+ void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<TypeBuilder::Array<int>>&) override;
+ void discardSearchResults(ErrorString*, const String& searchId) override;
+ void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<TypeBuilder::Runtime::RemoteObject>& result) override;
+ void getAttributes(ErrorString*, int nodeId, RefPtr<TypeBuilder::Array<String>>& result) override;
+ void setInspectModeEnabled(ErrorString*, bool enabled, const bool* inspectUAShadowDOM, const RefPtr<JSONObject>* highlightConfig) override;
+ void requestNode(ErrorString*, const String& objectId, int* nodeId) override;
+ void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId) override;
+ void pushNodesByBackendIdsToFrontend(ErrorString*, const RefPtr<JSONArray>& nodeIds, RefPtr<TypeBuilder::Array<int>>&) override;
+ void setInspectedNode(ErrorString*, int nodeId) override;
+ void hideHighlight(ErrorString*) override;
+ void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) override;
+ void highlightQuad(ErrorString*, const RefPtr<JSONArray>& quad, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) override;
+ void highlightNode(ErrorString*, const RefPtr<JSONObject>& highlightConfig, const int* nodeId, const int* backendNodeId, const String* objectId) override;
+ void highlightFrame(ErrorString*, const String& frameId, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) override;
+
+ void copyTo(ErrorString*, int nodeId, int targetElementId, const int* anchorNodeId, int* newNodeId) override;
+ void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId) override;
+ void undo(ErrorString*) override;
+ void redo(ErrorString*) override;
+ void markUndoableState(ErrorString*) override;
+ void focus(ErrorString*, int nodeId) override;
+ void setFileInputFiles(ErrorString*, int nodeId, const RefPtr<JSONArray>& files) override;
+ void getBoxModel(ErrorString*, int nodeId, RefPtr<TypeBuilder::DOM::BoxModel>&) override;
+ void getNodeForLocation(ErrorString*, int x, int y, int* nodeId) override;
+ void getRelayoutBoundary(ErrorString*, int nodeId, int* relayoutBoundaryNodeId) override;
+ void getHighlightObjectForTest(ErrorString*, int nodeId, RefPtr<JSONObject>&) override;
class CORE_EXPORT Listener : public WillBeGarbageCollectedMixin {
public:
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.h ('k') | Source/core/inspector/InspectorDOMAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698