Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Unified Diff: Source/core/workers/WorkerThread.cpp

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/workers/WorkerObjectProxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/workers/WorkerThread.cpp
diff --git a/Source/core/workers/WorkerThread.cpp b/Source/core/workers/WorkerThread.cpp
index d344974d29e59776b0c27b66428d8bfee32b9072..68d3fb4c7b5007c157150c383d12070c0c86820c 100644
--- a/Source/core/workers/WorkerThread.cpp
+++ b/Source/core/workers/WorkerThread.cpp
@@ -65,14 +65,14 @@ public:
{
}
- virtual void willProcessTask() override
+ void willProcessTask() override
{
// No tasks should get executed after we have closed.
WorkerGlobalScope* globalScope = m_workerThread->workerGlobalScope();
ASSERT_UNUSED(globalScope, !globalScope || !globalScope->isClosing());
}
- virtual void didProcessTask() override
+ void didProcessTask() override
{
Microtask::performCheckpoint(m_workerThread->isolate());
if (WorkerGlobalScope* globalScope = m_workerThread->workerGlobalScope()) {
@@ -117,9 +117,9 @@ public:
return adoptPtr(new WorkerThreadTask(workerThread, task, isInstrumented));
}
- virtual ~WorkerThreadTask() { }
+ ~WorkerThreadTask() override { }
- virtual void run() override
+ void run() override
{
WorkerGlobalScope* workerGlobalScope = m_workerThread.workerGlobalScope();
// If the thread is terminated before it had a chance initialize (see
« no previous file with comments | « Source/core/workers/WorkerObjectProxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698