Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: Source/core/frame/DOMWindow.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/DOMTimer.h ('k') | Source/core/frame/DeviceSingleWindowEventController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMWindow.h
diff --git a/Source/core/frame/DOMWindow.h b/Source/core/frame/DOMWindow.h
index f2f2ac4ecb1da6feaaa2352a658619efc921744e..e5a8dadd68e1b15a1f2e70d76fce7fdcfb3cfa5f 100644
--- a/Source/core/frame/DOMWindow.h
+++ b/Source/core/frame/DOMWindow.h
@@ -43,7 +43,7 @@ class CORE_EXPORT DOMWindow : public EventTargetWithInlineData, public RefCounte
DEFINE_WRAPPERTYPEINFO();
REFCOUNTED_EVENT_TARGET(DOMWindow);
public:
- virtual ~DOMWindow();
+ ~DOMWindow() override;
// RefCountedWillBeGarbageCollectedFinalized overrides:
DECLARE_VIRTUAL_TRACE();
@@ -54,8 +54,8 @@ public:
virtual Frame* frame() const = 0;
// ScriptWrappable overrides:
- v8::Local<v8::Object> wrap(v8::Isolate*, v8::Local<v8::Object> creationContext) override final;
- v8::Local<v8::Object> associateWithWrapper(v8::Isolate*, const WrapperTypeInfo*, v8::Local<v8::Object> wrapper) override final;
+ v8::Local<v8::Object> wrap(v8::Isolate*, v8::Local<v8::Object> creationContext) final;
+ v8::Local<v8::Object> associateWithWrapper(v8::Isolate*, const WrapperTypeInfo*, v8::Local<v8::Object> wrapper) final;
// EventTarget overrides:
const AtomicString& interfaceName() const override;
« no previous file with comments | « Source/core/frame/DOMTimer.h ('k') | Source/core/frame/DeviceSingleWindowEventController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698