Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Unified Diff: Source/core/inspector/PageConsoleAgent.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorWorkerAgent.cpp ('k') | Source/core/inspector/PageRuntimeAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PageConsoleAgent.h
diff --git a/Source/core/inspector/PageConsoleAgent.h b/Source/core/inspector/PageConsoleAgent.h
index ab026729400e6363d0fd4b2340a93b6a692c6588..2fba556083df916a54dca4f8bb3c4d111d5bfea5 100644
--- a/Source/core/inspector/PageConsoleAgent.h
+++ b/Source/core/inspector/PageConsoleAgent.h
@@ -51,25 +51,25 @@ public:
{
return adoptPtrWillBeNoop(new PageConsoleAgent(injectedScriptManager, domAgent, pageAgent));
}
- virtual ~PageConsoleAgent();
+ ~PageConsoleAgent() override;
DECLARE_VIRTUAL_TRACE();
- virtual void enable(ErrorString*) override;
- virtual void disable(ErrorString*) override;
+ void enable(ErrorString*) override;
+ void disable(ErrorString*) override;
void workerTerminated(WorkerInspectorProxy*);
void workerConsoleAgentEnabled(WorkerGlobalScopeProxy*);
protected:
- virtual ConsoleMessageStorage* messageStorage() override;
+ ConsoleMessageStorage* messageStorage() override;
- virtual void enableStackCapturingIfNeeded() override;
- virtual void disableStackCapturingIfNeeded() override;
+ void enableStackCapturingIfNeeded() override;
+ void disableStackCapturingIfNeeded() override;
private:
PageConsoleAgent(InjectedScriptManager*, InspectorDOMAgent*, InspectorPageAgent*);
- virtual void clearMessages(ErrorString*) override;
+ void clearMessages(ErrorString*) override;
RawPtrWillBeMember<InspectorDOMAgent> m_inspectorDOMAgent;
RawPtrWillBeMember<InspectorPageAgent> m_pageAgent;
« no previous file with comments | « Source/core/inspector/InspectorWorkerAgent.cpp ('k') | Source/core/inspector/PageRuntimeAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698