Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: Source/core/page/PageSerializer.cpp

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/Page.h ('k') | Source/core/page/PrintContextTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 static const QualifiedName& frameOwnerURLAttributeName(const HTMLFrameOwnerEleme nt& frameOwner) 96 static const QualifiedName& frameOwnerURLAttributeName(const HTMLFrameOwnerEleme nt& frameOwner)
97 { 97 {
98 // FIXME: We should support all frame owners including applets. 98 // FIXME: We should support all frame owners including applets.
99 return isHTMLObjectElement(frameOwner) ? HTMLNames::dataAttr : HTMLNames::sr cAttr; 99 return isHTMLObjectElement(frameOwner) ? HTMLNames::dataAttr : HTMLNames::sr cAttr;
100 } 100 }
101 101
102 class SerializerMarkupAccumulator : public MarkupAccumulator { 102 class SerializerMarkupAccumulator : public MarkupAccumulator {
103 STACK_ALLOCATED(); 103 STACK_ALLOCATED();
104 public: 104 public:
105 SerializerMarkupAccumulator(PageSerializer*, const Document&, WillBeHeapVect or<RawPtrWillBeMember<Node>>&); 105 SerializerMarkupAccumulator(PageSerializer*, const Document&, WillBeHeapVect or<RawPtrWillBeMember<Node>>&);
106 virtual ~SerializerMarkupAccumulator(); 106 ~SerializerMarkupAccumulator() override;
107 107
108 protected: 108 protected:
109 virtual void appendText(StringBuilder& out, Text&) override; 109 void appendText(StringBuilder& out, Text&) override;
110 virtual bool shouldIgnoreAttribute(const Attribute&) override; 110 bool shouldIgnoreAttribute(const Attribute&) override;
111 virtual void appendElement(StringBuilder& out, Element&, Namespaces*) overri de; 111 void appendElement(StringBuilder& out, Element&, Namespaces*) override;
112 virtual void appendCustomAttributes(StringBuilder& out, const Element&, Name spaces*) override; 112 void appendCustomAttributes(StringBuilder& out, const Element&, Namespaces*) override;
113 virtual void appendStartTag(Node&, Namespaces* = nullptr) override; 113 void appendStartTag(Node&, Namespaces* = nullptr) override;
114 virtual void appendEndTag(const Element&) override; 114 void appendEndTag(const Element&) override;
115 115
116 const Document& document(); 116 const Document& document();
117 117
118 private: 118 private:
119 PageSerializer* m_serializer; 119 PageSerializer* m_serializer;
120 RawPtrWillBeMember<const Document> m_document; 120 RawPtrWillBeMember<const Document> m_document;
121 121
122 // FIXME: |PageSerializer| uses |m_nodes| for collecting nodes in document 122 // FIXME: |PageSerializer| uses |m_nodes| for collecting nodes in document
123 // included into serialized text then extracts image, object, etc. The size 123 // included into serialized text then extracts image, object, etc. The size
124 // of this vector isn't small for large document. It is better to use 124 // of this vector isn't small for large document. It is better to use
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 571
572 return fakeURL; 572 return fakeURL;
573 } 573 }
574 574
575 PageSerializer::Delegate* PageSerializer::delegate() 575 PageSerializer::Delegate* PageSerializer::delegate()
576 { 576 {
577 return m_delegate.get(); 577 return m_delegate.get();
578 } 578 }
579 579
580 } // namespace blink 580 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/page/Page.h ('k') | Source/core/page/PrintContextTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698