Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: Source/core/imagebitmap/ImageBitmapFactories.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/SuspendableTimer.h ('k') | Source/core/inspector/AsyncCallTracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/imagebitmap/ImageBitmapFactories.h
diff --git a/Source/core/imagebitmap/ImageBitmapFactories.h b/Source/core/imagebitmap/ImageBitmapFactories.h
index 5de8f8b8ea7871c78da56d9149f78867659f8786..401360ac8accc646b28ed0493aaa9e4be573ec08 100644
--- a/Source/core/imagebitmap/ImageBitmapFactories.h
+++ b/Source/core/imagebitmap/ImageBitmapFactories.h
@@ -81,7 +81,7 @@ private:
DECLARE_TRACE();
- virtual ~ImageBitmapLoader() { }
+ ~ImageBitmapLoader() override { }
private:
ImageBitmapLoader(ImageBitmapFactories&, const IntRect&, ScriptState*);
@@ -89,10 +89,10 @@ private:
void rejectPromise();
// FileReaderLoaderClient
- virtual void didStartLoading() override { }
- virtual void didReceiveData() override { }
- virtual void didFinishLoading() override;
- virtual void didFail(FileError::ErrorCode) override;
+ void didStartLoading() override { }
+ void didReceiveData() override { }
+ void didFinishLoading() override;
+ void didFail(FileError::ErrorCode) override;
FileReaderLoader m_loader;
RawPtrWillBeMember<ImageBitmapFactories> m_factory;
« no previous file with comments | « Source/core/frame/SuspendableTimer.h ('k') | Source/core/inspector/AsyncCallTracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698