Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1928)

Unified Diff: Source/core/workers/WorkerObjectProxy.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/workers/WorkerNavigator.h ('k') | Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/workers/WorkerObjectProxy.h
diff --git a/Source/core/workers/WorkerObjectProxy.h b/Source/core/workers/WorkerObjectProxy.h
index ebf1d380628db0be803f2cdff13ed904ad448f5c..7ca2d5d8bbd914caf1f0fd52469a7ce1b452de1a 100644
--- a/Source/core/workers/WorkerObjectProxy.h
+++ b/Source/core/workers/WorkerObjectProxy.h
@@ -53,7 +53,7 @@ class WorkerMessagingProxy;
class CORE_EXPORT WorkerObjectProxy : public WorkerReportingProxy {
public:
static PassOwnPtr<WorkerObjectProxy> create(ExecutionContext*, WorkerMessagingProxy*);
- virtual ~WorkerObjectProxy() { }
+ ~WorkerObjectProxy() override { }
void postMessageToWorkerObject(PassRefPtr<SerializedScriptValue>, PassOwnPtr<MessagePortChannelArray>);
void postTaskToMainExecutionContext(PassOwnPtr<ExecutionContextTask>);
@@ -61,15 +61,15 @@ public:
void reportPendingActivity(bool hasPendingActivity);
// WorkerReportingProxy overrides.
- virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;
- virtual void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;
- virtual void postMessageToPageInspector(const String&) override;
- virtual void postWorkerConsoleAgentEnabled() override;
- virtual void didEvaluateWorkerScript(bool success) override { }
- virtual void workerGlobalScopeStarted(WorkerGlobalScope*) override { }
- virtual void workerGlobalScopeClosed() override;
- virtual void workerThreadTerminated() override;
- virtual void willDestroyWorkerGlobalScope() override { }
+ void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;
+ void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;
+ void postMessageToPageInspector(const String&) override;
+ void postWorkerConsoleAgentEnabled() override;
+ void didEvaluateWorkerScript(bool success) override { }
+ void workerGlobalScopeStarted(WorkerGlobalScope*) override { }
+ void workerGlobalScopeClosed() override;
+ void workerThreadTerminated() override;
+ void willDestroyWorkerGlobalScope() override { }
protected:
WorkerObjectProxy(ExecutionContext*, WorkerMessagingProxy*);
« no previous file with comments | « Source/core/workers/WorkerNavigator.h ('k') | Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698