Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
bbudge
CC:
chromium-reviews, scheib+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in ppapi. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3 Cr-Commit-Position: refs/heads/master@{#326505}

Patch Set 1 #

Patch Set 2 : reupload because random xml file #

Patch Set 3 : Split off one file into separate review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1140 lines, -1202 lines) Patch
M ppapi/host/ppapi_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/host/resource_host.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/host/resource_message_filter.h View 2 chunks +8 lines, -9 lines 0 comments Download
M ppapi/host/resource_message_filter_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M ppapi/nacl_irt/manifest_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/nacl_irt/ppapi_dispatcher.h View 1 chunk +17 lines, -19 lines 0 comments Download
M ppapi/proxy/audio_buffer_resource.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ppapi/proxy/audio_input_resource.h View 2 chunks +24 lines, -26 lines 0 comments Download
M ppapi/proxy/broker_dispatcher.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/broker_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/browser_font_singleton_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/compositor_layer_resource.h View 1 chunk +16 lines, -16 lines 0 comments Download
M ppapi/proxy/compositor_resource.h View 1 chunk +7 lines, -8 lines 0 comments Download
M ppapi/proxy/device_enumeration_resource_helper_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/file_chooser_resource.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ppapi/proxy/file_io_resource.h View 1 chunk +31 lines, -33 lines 0 comments Download
M ppapi/proxy/file_ref_resource.h View 1 chunk +18 lines, -19 lines 0 comments Download
M ppapi/proxy/file_system_resource.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ppapi/proxy/flash_clipboard_resource.h View 1 chunk +15 lines, -15 lines 0 comments Download
M ppapi/proxy/flash_drm_resource.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ppapi/proxy/flash_file_resource.h View 1 chunk +29 lines, -29 lines 0 comments Download
M ppapi/proxy/flash_font_file_resource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/flash_fullscreen_resource.h View 1 chunk +6 lines, -8 lines 0 comments Download
M ppapi/proxy/flash_menu_resource.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ppapi/proxy/flash_resource.h View 2 chunks +17 lines, -22 lines 0 comments Download
M ppapi/proxy/gamepad_resource.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ppapi/proxy/graphics_2d_resource.h View 1 chunk +12 lines, -14 lines 0 comments Download
M ppapi/proxy/host_resolver_private_resource.h View 1 chunk +10 lines, -11 lines 0 comments Download
M ppapi/proxy/host_resolver_resource.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ppapi/proxy/isolated_file_system_private_resource.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/media_stream_audio_track_resource.h View 1 chunk +14 lines, -15 lines 0 comments Download
M ppapi/proxy/media_stream_track_resource_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/media_stream_video_track_resource.h View 1 chunk +17 lines, -17 lines 0 comments Download
M ppapi/proxy/net_address_resource.h View 1 chunk +7 lines, -9 lines 0 comments Download
M ppapi/proxy/network_list_resource.h View 1 chunk +9 lines, -10 lines 0 comments Download
M ppapi/proxy/network_monitor_resource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/network_proxy_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/output_protection_resource.h View 1 chunk +4 lines, -5 lines 0 comments Download
M ppapi/proxy/pdf_resource.h View 2 chunks +26 lines, -26 lines 0 comments Download
M ppapi/proxy/platform_verification_private_resource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_array_buffer_var.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/plugin_globals.h View 3 chunks +20 lines, -22 lines 0 comments Download
M ppapi/proxy/plugin_globals.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_message_filter.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/plugin_resource.h View 2 chunks +5 lines, -6 lines 0 comments Download
M ppapi/proxy/plugin_resource_callback.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_resource_var.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker.h View 3 chunks +20 lines, -21 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +30 lines, -31 lines 0 comments Download
M ppapi/proxy/ppb_broker_proxy.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_buffer_proxy.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ppapi/proxy/ppb_flash_message_loop_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_message_loop_proxy.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 3 chunks +18 lines, -19 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 5 chunks +19 lines, -19 lines 0 comments Download
M ppapi/proxy/ppb_message_loop_proxy.h View 2 chunks +11 lines, -12 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M ppapi/proxy/ppb_x509_certificate_private_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_x509_certificate_private_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_mouse_lock_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_text_input_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/printing_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/proxy_channel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/proxy_object_var.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/raw_var_data.h View 6 chunks +61 lines, -67 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 3 chunks +91 lines, -98 lines 0 comments Download
M ppapi/proxy/resource_message_params.h View 2 chunks +6 lines, -8 lines 0 comments Download
M ppapi/proxy/resource_message_test_sink.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/tcp_server_socket_private_resource.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ppapi/proxy/tcp_socket_private_resource.h View 1 chunk +23 lines, -23 lines 0 comments Download
M ppapi/proxy/tcp_socket_resource.h View 1 chunk +24 lines, -24 lines 0 comments Download
M ppapi/proxy/truetype_font_resource.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ppapi/proxy/truetype_font_singleton_resource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/udp_socket_private_resource.h View 1 chunk +16 lines, -17 lines 0 comments Download
M ppapi/proxy/udp_socket_resource.h View 1 chunk +23 lines, -23 lines 0 comments Download
M ppapi/proxy/uma_private_resource.h View 1 chunk +22 lines, -22 lines 0 comments Download
M ppapi/proxy/url_loader_resource.h View 1 chunk +18 lines, -19 lines 0 comments Download
M ppapi/proxy/url_request_info_resource.h View 1 chunk +6 lines, -7 lines 0 comments Download
M ppapi/proxy/url_response_info_resource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/video_capture_resource.h View 2 chunks +16 lines, -16 lines 0 comments Download
M ppapi/proxy/video_decoder_resource.h View 1 chunk +19 lines, -19 lines 0 comments Download
M ppapi/proxy/video_destination_resource.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/video_frame_resource.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ppapi/proxy/video_source_resource.h View 1 chunk +5 lines, -6 lines 0 comments Download
M ppapi/proxy/websocket_resource.h View 1 chunk +21 lines, -21 lines 0 comments Download
M ppapi/shared_impl/array_var.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/shared_impl/dictionary_var.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/shared_impl/media_stream_buffer_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/ppb_audio_config_shared.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/shared_impl/ppb_device_ref_shared.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.h View 2 chunks +19 lines, -19 lines 0 comments Download
M ppapi/shared_impl/ppb_input_event_shared.h View 1 chunk +25 lines, -27 lines 0 comments Download
M ppapi/shared_impl/ppb_instance_shared.h View 1 chunk +6 lines, -8 lines 0 comments Download
M ppapi/shared_impl/ppb_video_decoder_shared.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ppapi/shared_impl/ppb_view_shared.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h View 1 chunk +4 lines, -5 lines 0 comments Download
M ppapi/shared_impl/resource_tracker_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/shared_impl/resource_var.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/shared_impl/test_globals.h View 2 chunks +35 lines, -37 lines 0 comments Download
M ppapi/shared_impl/thread_aware_callback_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ppapi/shared_impl/var.h View 4 chunks +6 lines, -6 lines 0 comments Download
M ppapi/shared_impl/var_tracker_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/tests/test_flash_fullscreen_for_browser_ui.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ncarter (slow)
dmichael: Please review this boring change.
5 years, 8 months ago (2015-04-23 03:51:29 UTC) #2
ncarter (slow)
bbudge: Please review this boring change.
5 years, 8 months ago (2015-04-23 03:52:33 UTC) #5
bbudge
Let's hope it's boring. LGTM
5 years, 8 months ago (2015-04-23 13:35:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097393007/40001
5 years, 8 months ago (2015-04-23 13:52:56 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-23 14:01:56 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 14:03:19 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3
Cr-Commit-Position: refs/heads/master@{#326505}

Powered by Google App Engine
This is Rietveld 408576698