Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: ppapi/shared_impl/ppb_graphics_3d_shared.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/shared_impl/ppb_device_ref_shared.h ('k') | ppapi/shared_impl/ppb_input_event_shared.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/ppb_graphics_3d_shared.h
diff --git a/ppapi/shared_impl/ppb_graphics_3d_shared.h b/ppapi/shared_impl/ppb_graphics_3d_shared.h
index 8df6219aea644aacdc8a4893f060fe14696d1046..09bc0f53829bc3c7765d86c96f624320db9d1fdd 100644
--- a/ppapi/shared_impl/ppb_graphics_3d_shared.h
+++ b/ppapi/shared_impl/ppb_graphics_3d_shared.h
@@ -30,26 +30,26 @@ class PPAPI_SHARED_EXPORT PPB_Graphics3D_Shared
public thunk::PPB_Graphics3D_API {
public:
// Resource overrides.
- virtual thunk::PPB_Graphics3D_API* AsPPB_Graphics3D_API() override;
+ thunk::PPB_Graphics3D_API* AsPPB_Graphics3D_API() override;
// PPB_Graphics3D_API implementation.
- virtual int32_t GetAttribs(int32_t attrib_list[]) override;
- virtual int32_t SetAttribs(const int32_t attrib_list[]) override;
- virtual int32_t GetError() override;
- virtual int32_t ResizeBuffers(int32_t width, int32_t height) override;
- virtual int32_t SwapBuffers(scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t GetAttribMaxValue(int32_t attribute, int32_t* value) override;
-
- virtual void* MapTexSubImage2DCHROMIUM(GLenum target,
- GLint level,
- GLint xoffset,
- GLint yoffset,
- GLsizei width,
- GLsizei height,
- GLenum format,
- GLenum type,
- GLenum access) override;
- virtual void UnmapTexSubImage2DCHROMIUM(const void* mem) override;
+ int32_t GetAttribs(int32_t attrib_list[]) override;
+ int32_t SetAttribs(const int32_t attrib_list[]) override;
+ int32_t GetError() override;
+ int32_t ResizeBuffers(int32_t width, int32_t height) override;
+ int32_t SwapBuffers(scoped_refptr<TrackedCallback> callback) override;
+ int32_t GetAttribMaxValue(int32_t attribute, int32_t* value) override;
+
+ void* MapTexSubImage2DCHROMIUM(GLenum target,
+ GLint level,
+ GLint xoffset,
+ GLint yoffset,
+ GLsizei width,
+ GLsizei height,
+ GLenum format,
+ GLenum type,
+ GLenum access) override;
+ void UnmapTexSubImage2DCHROMIUM(const void* mem) override;
gpu::gles2::GLES2Implementation* gles2_impl() { return gles2_impl_.get(); }
@@ -59,7 +59,7 @@ class PPAPI_SHARED_EXPORT PPB_Graphics3D_Shared
protected:
PPB_Graphics3D_Shared(PP_Instance instance);
PPB_Graphics3D_Shared(const HostResource& host_resource);
- virtual ~PPB_Graphics3D_Shared();
+ ~PPB_Graphics3D_Shared() override;
virtual gpu::CommandBuffer* GetCommandBuffer() = 0;
virtual gpu::GpuControl* GetGpuControl() = 0;
« no previous file with comments | « ppapi/shared_impl/ppb_device_ref_shared.h ('k') | ppapi/shared_impl/ppb_input_event_shared.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698