Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: ppapi/shared_impl/array_var.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/proxy/websocket_resource.h ('k') | ppapi/shared_impl/dictionary_var.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PPAPI_SHARED_IMPL_ARRAY_VAR_H_ 5 #ifndef PPAPI_SHARED_IMPL_ARRAY_VAR_H_
6 #define PPAPI_SHARED_IMPL_ARRAY_VAR_H_ 6 #define PPAPI_SHARED_IMPL_ARRAY_VAR_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 10 matching lines...) Expand all
21 typedef std::vector<ScopedPPVar> ElementVector; 21 typedef std::vector<ScopedPPVar> ElementVector;
22 22
23 ArrayVar(); 23 ArrayVar();
24 24
25 // Helper function that converts a PP_Var to an ArrayVar. This will return 25 // Helper function that converts a PP_Var to an ArrayVar. This will return
26 // NULL if the PP_Var is not of type PP_VARTYPE_ARRAY or the array cannot be 26 // NULL if the PP_Var is not of type PP_VARTYPE_ARRAY or the array cannot be
27 // found from the var tracker. 27 // found from the var tracker.
28 static ArrayVar* FromPPVar(const PP_Var& var); 28 static ArrayVar* FromPPVar(const PP_Var& var);
29 29
30 // Var overrides. 30 // Var overrides.
31 virtual ArrayVar* AsArrayVar() override; 31 ArrayVar* AsArrayVar() override;
32 virtual PP_VarType GetType() const override; 32 PP_VarType GetType() const override;
33 33
34 // The returned PP_Var has had a ref added on behalf of the caller. 34 // The returned PP_Var has had a ref added on behalf of the caller.
35 PP_Var Get(uint32_t index) const; 35 PP_Var Get(uint32_t index) const;
36 PP_Bool Set(uint32_t index, const PP_Var& value); 36 PP_Bool Set(uint32_t index, const PP_Var& value);
37 uint32_t GetLength() const; 37 uint32_t GetLength() const;
38 PP_Bool SetLength(uint32_t length); 38 PP_Bool SetLength(uint32_t length);
39 39
40 const ElementVector& elements() const { return elements_; } 40 const ElementVector& elements() const { return elements_; }
41 41
42 ElementVector& elements() { return elements_; } 42 ElementVector& elements() { return elements_; }
43 43
44 protected: 44 protected:
45 virtual ~ArrayVar(); 45 ~ArrayVar() override;
46 46
47 private: 47 private:
48 ElementVector elements_; 48 ElementVector elements_;
49 49
50 DISALLOW_COPY_AND_ASSIGN(ArrayVar); 50 DISALLOW_COPY_AND_ASSIGN(ArrayVar);
51 }; 51 };
52 52
53 } // namespace ppapi 53 } // namespace ppapi
54 54
55 #endif // PPAPI_SHARED_IMPL_ARRAY_VAR_H_ 55 #endif // PPAPI_SHARED_IMPL_ARRAY_VAR_H_
OLDNEW
« no previous file with comments | « ppapi/proxy/websocket_resource.h ('k') | ppapi/shared_impl/dictionary_var.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698