Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: ppapi/proxy/uma_private_resource.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/proxy/udp_socket_resource.h ('k') | ppapi/proxy/url_loader_resource.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PPAPI_PROXY_UMA_PRIVATE_RESOURCE_H_ 5 #ifndef PPAPI_PROXY_UMA_PRIVATE_RESOURCE_H_
6 #define PPAPI_PROXY_UMA_PRIVATE_RESOURCE_H_ 6 #define PPAPI_PROXY_UMA_PRIVATE_RESOURCE_H_
7 7
8 #include "ppapi/proxy/connection.h" 8 #include "ppapi/proxy/connection.h"
9 #include "ppapi/proxy/plugin_resource.h" 9 #include "ppapi/proxy/plugin_resource.h"
10 #include "ppapi/proxy/ppapi_proxy_export.h" 10 #include "ppapi/proxy/ppapi_proxy_export.h"
11 #include "ppapi/thunk/ppb_uma_singleton_api.h" 11 #include "ppapi/thunk/ppb_uma_singleton_api.h"
12 12
13 namespace ppapi { 13 namespace ppapi {
14 14
15 namespace proxy { 15 namespace proxy {
16 16
17 class PPAPI_PROXY_EXPORT UMAPrivateResource 17 class PPAPI_PROXY_EXPORT UMAPrivateResource
18 : public PluginResource, 18 : public PluginResource,
19 public thunk::PPB_UMA_Singleton_API { 19 public thunk::PPB_UMA_Singleton_API {
20 public: 20 public:
21 UMAPrivateResource(Connection connection, PP_Instance instance); 21 UMAPrivateResource(Connection connection, PP_Instance instance);
22 virtual ~UMAPrivateResource(); 22 ~UMAPrivateResource() override;
23 23
24 // Resource overrides. 24 // Resource overrides.
25 virtual thunk::PPB_UMA_Singleton_API* AsPPB_UMA_Singleton_API() override; 25 thunk::PPB_UMA_Singleton_API* AsPPB_UMA_Singleton_API() override;
26 26
27 // PPB_UMA_Singleton_API implementation. 27 // PPB_UMA_Singleton_API implementation.
28 virtual void HistogramCustomTimes(PP_Instance instance, 28 void HistogramCustomTimes(PP_Instance instance,
29 struct PP_Var name, 29 struct PP_Var name,
30 int64_t sample, 30 int64_t sample,
31 int64_t min, 31 int64_t min,
32 int64_t max, 32 int64_t max,
33 uint32_t bucket_count) override; 33 uint32_t bucket_count) override;
34 34
35 virtual void HistogramCustomCounts(PP_Instance instance, 35 void HistogramCustomCounts(PP_Instance instance,
36 struct PP_Var name, 36 struct PP_Var name,
37 int32_t sample, 37 int32_t sample,
38 int32_t min, 38 int32_t min,
39 int32_t max, 39 int32_t max,
40 uint32_t bucket_count) override; 40 uint32_t bucket_count) override;
41 41
42 virtual void HistogramEnumeration(PP_Instance instance, 42 void HistogramEnumeration(PP_Instance instance,
43 struct PP_Var name, 43 struct PP_Var name,
44 int32_t sample, 44 int32_t sample,
45 int32_t boundary_value) override; 45 int32_t boundary_value) override;
46 46
47 virtual int32_t IsCrashReportingEnabled( 47 int32_t IsCrashReportingEnabled(
48 PP_Instance instance, 48 PP_Instance instance,
49 scoped_refptr<TrackedCallback> callback) override; 49 scoped_refptr<TrackedCallback> callback) override;
50 50
51 private: 51 private:
52 void OnPluginMsgIsCrashReportingEnabled( 52 void OnPluginMsgIsCrashReportingEnabled(
53 const ResourceMessageReplyParams& params); 53 const ResourceMessageReplyParams& params);
54 scoped_refptr<TrackedCallback> pending_callback_; 54 scoped_refptr<TrackedCallback> pending_callback_;
55 55
56 DISALLOW_COPY_AND_ASSIGN(UMAPrivateResource); 56 DISALLOW_COPY_AND_ASSIGN(UMAPrivateResource);
57 }; 57 };
58 58
59 } // namespace proxy 59 } // namespace proxy
60 } // namespace ppapi 60 } // namespace ppapi
61 61
62 #endif // PPAPI_PROXY_UMA_PRIVATE_RESOURCE_H_ 62 #endif // PPAPI_PROXY_UMA_PRIVATE_RESOURCE_H_
OLDNEW
« no previous file with comments | « ppapi/proxy/udp_socket_resource.h ('k') | ppapi/proxy/url_loader_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698