Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: ppapi/proxy/url_loader_resource.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/uma_private_resource.h ('k') | ppapi/proxy/url_request_info_resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/url_loader_resource.h
diff --git a/ppapi/proxy/url_loader_resource.h b/ppapi/proxy/url_loader_resource.h
index 457dd4afa58cb63050dc22fdf1b40185578184e5..f96c1aba2e44ecb047d7c0460418a393d4d835e5 100644
--- a/ppapi/proxy/url_loader_resource.h
+++ b/ppapi/proxy/url_loader_resource.h
@@ -36,39 +36,38 @@ class PPAPI_PROXY_EXPORT URLLoaderResource
int pending_main_document_loader_id,
const URLResponseInfoData& data);
- virtual ~URLLoaderResource();
+ ~URLLoaderResource() override;
// Resource override.
thunk::PPB_URLLoader_API* AsPPB_URLLoader_API() override;
// PPB_URLLoader_API implementation.
- virtual int32_t Open(PP_Resource request_id,
- scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t Open(const URLRequestInfoData& data,
- int requestor_pid,
- scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t FollowRedirect(
- scoped_refptr<TrackedCallback> callback) override;
- virtual PP_Bool GetUploadProgress(int64_t* bytes_sent,
- int64_t* total_bytes_to_be_sent) override;
- virtual PP_Bool GetDownloadProgress(
+ int32_t Open(PP_Resource request_id,
+ scoped_refptr<TrackedCallback> callback) override;
+ int32_t Open(const URLRequestInfoData& data,
+ int requestor_pid,
+ scoped_refptr<TrackedCallback> callback) override;
+ int32_t FollowRedirect(scoped_refptr<TrackedCallback> callback) override;
+ PP_Bool GetUploadProgress(int64_t* bytes_sent,
+ int64_t* total_bytes_to_be_sent) override;
+ PP_Bool GetDownloadProgress(
int64_t* bytes_received,
int64_t* total_bytes_to_be_received) override;
- virtual PP_Resource GetResponseInfo() override;
- virtual int32_t ReadResponseBody(
+ PP_Resource GetResponseInfo() override;
+ int32_t ReadResponseBody(
void* buffer,
int32_t bytes_to_read,
scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t FinishStreamingToFile(
+ int32_t FinishStreamingToFile(
scoped_refptr<TrackedCallback> callback) override;
- virtual void Close() override;
- virtual void GrantUniversalAccess() override;
- virtual void RegisterStatusCallback(
+ void Close() override;
+ void GrantUniversalAccess() override;
+ void RegisterStatusCallback(
PP_URLLoaderTrusted_StatusCallback callback) override;
// PluginResource implementation.
- virtual void OnReplyReceived(const ResourceMessageReplyParams& params,
- const IPC::Message& msg) override;
+ void OnReplyReceived(const ResourceMessageReplyParams& params,
+ const IPC::Message& msg) override;
private:
enum Mode {
« no previous file with comments | « ppapi/proxy/uma_private_resource.h ('k') | ppapi/proxy/url_request_info_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698