Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: ppapi/host/resource_message_filter.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/host/resource_host.h ('k') | ppapi/host/resource_message_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/host/resource_message_filter.h
diff --git a/ppapi/host/resource_message_filter.h b/ppapi/host/resource_message_filter.h
index af7a4f66908809e91cba8adfb933d17ac719f1a1..5488f98a4bdb0a47df95880ff19a2605b2df8028 100644
--- a/ppapi/host/resource_message_filter.h
+++ b/ppapi/host/resource_message_filter.h
@@ -48,16 +48,15 @@ struct PPAPI_HOST_EXPORT ResourceMessageFilterDeleteTraits {
// subclass as follows:
// class MyMessageFilter : public ResourceMessageFilter {
// protected:
-// virtual scoped_refptr<base::TaskRunner> OverrideTaskRunnerForMessage(
+// scoped_refptr<base::TaskRunner> OverrideTaskRunnerForMessage(
// const IPC::Message& message) override {
// if (message.type() == MyMessage::ID)
// return BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI);
// return NULL;
// }
//
-// virtual int32_t OnResourceMessageReceived(
-// const IPC::Message& msg,
-// HostMessageContext* context) override {
+// int32_t OnResourceMessageReceived(const IPC::Message& msg,
+// HostMessageContext* context) override {
// IPC_BEGIN_MESSAGE_MAP(MyMessageFilter, msg)
// PPAPI_DISPATCH_HOST_RESOURCE_CALL(MyMessage, OnMyMessage)
// IPC_END_MESSAGE_MAP()
@@ -96,15 +95,15 @@ class PPAPI_HOST_EXPORT ResourceMessageFilter
// This will dispatch the message handler on the target thread. It returns
// true if the message was handled by this filter and false otherwise.
- virtual bool HandleMessage(const IPC::Message& msg,
- HostMessageContext* context) override;
+ bool HandleMessage(const IPC::Message& msg,
+ HostMessageContext* context) override;
// This can be called from any thread.
- virtual void SendReply(const ReplyMessageContext& context,
- const IPC::Message& msg) override;
+ void SendReply(const ReplyMessageContext& context,
+ const IPC::Message& msg) override;
protected:
- virtual ~ResourceMessageFilter();
+ ~ResourceMessageFilter() override;
// Please see the comments of |resource_host_| for on which thread it can be
// used and when it is NULL.
« no previous file with comments | « ppapi/host/resource_host.h ('k') | ppapi/host/resource_message_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698