Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: ppapi/shared_impl/ppb_instance_shared.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PPAPI_SHARED_IMPL_PPB_INSTANCE_SHARED_H_ 5 #ifndef PPAPI_SHARED_IMPL_PPB_INSTANCE_SHARED_H_
6 #define PPAPI_SHARED_IMPL_PPB_INSTANCE_SHARED_H_ 6 #define PPAPI_SHARED_IMPL_PPB_INSTANCE_SHARED_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "ppapi/c/pp_stdint.h" 9 #include "ppapi/c/pp_stdint.h"
10 #include "ppapi/shared_impl/ppapi_shared_export.h" 10 #include "ppapi/shared_impl/ppapi_shared_export.h"
11 #include "ppapi/thunk/ppb_instance_api.h" 11 #include "ppapi/thunk/ppb_instance_api.h"
12 12
13 namespace ppapi { 13 namespace ppapi {
14 14
15 class PPAPI_SHARED_EXPORT PPB_Instance_Shared 15 class PPAPI_SHARED_EXPORT PPB_Instance_Shared
16 : NON_EXPORTED_BASE(public thunk::PPB_Instance_API) { 16 : NON_EXPORTED_BASE(public thunk::PPB_Instance_API) {
17 public: 17 public:
18 virtual ~PPB_Instance_Shared(); 18 ~PPB_Instance_Shared() override;
19 19
20 // Implementation of some shared PPB_Instance_FunctionAPI functions. 20 // Implementation of some shared PPB_Instance_FunctionAPI functions.
21 virtual void Log(PP_Instance instance, 21 void Log(PP_Instance instance, PP_LogLevel log_level, PP_Var value) override;
22 PP_LogLevel log_level, 22 void LogWithSource(PP_Instance instance,
23 PP_Var value) override; 23 PP_LogLevel log_level,
24 virtual void LogWithSource(PP_Instance instance, 24 PP_Var source,
25 PP_LogLevel log_level, 25 PP_Var value) override;
26 PP_Var source,
27 PP_Var value) override;
28 26
29 // Error checks the given resquest to Request[Filtering]InputEvents. Returns 27 // Error checks the given resquest to Request[Filtering]InputEvents. Returns
30 // PP_OK if the given classes are all valid, PP_ERROR_NOTSUPPORTED if not. 28 // PP_OK if the given classes are all valid, PP_ERROR_NOTSUPPORTED if not.
31 int32_t ValidateRequestInputEvents(bool is_filtering, uint32_t event_classes); 29 int32_t ValidateRequestInputEvents(bool is_filtering, uint32_t event_classes);
32 30
33 bool ValidateSetCursorParams(PP_MouseCursor_Type type, 31 bool ValidateSetCursorParams(PP_MouseCursor_Type type,
34 PP_Resource image, 32 PP_Resource image,
35 const PP_Point* hot_spot); 33 const PP_Point* hot_spot);
36 34
37 // The length of text to request as a surrounding context of selection. 35 // The length of text to request as a surrounding context of selection.
38 // For now, the value is copied from the one with render_view_impl.cc. 36 // For now, the value is copied from the one with render_view_impl.cc.
39 // TODO(kinaba) implement a way to dynamically sync the requirement. 37 // TODO(kinaba) implement a way to dynamically sync the requirement.
40 static const int kExtraCharsForTextInput; 38 static const int kExtraCharsForTextInput;
41 }; 39 };
42 40
43 } // namespace ppapi 41 } // namespace ppapi
44 42
45 #endif // PPAPI_SHARED_IMPL_PPB_INSTANCE_SHARED_H_ 43 #endif // PPAPI_SHARED_IMPL_PPB_INSTANCE_SHARED_H_
OLDNEW
« no previous file with comments | « ppapi/shared_impl/ppb_input_event_shared.h ('k') | ppapi/shared_impl/ppb_video_decoder_shared.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698