Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: ppapi/proxy/pdf_resource.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/output_protection_resource.h ('k') | ppapi/proxy/platform_verification_private_resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/pdf_resource.h
diff --git a/ppapi/proxy/pdf_resource.h b/ppapi/proxy/pdf_resource.h
index 9ca82c63e4cb778d5989789bca7fb99a544bd657..f68c1a2d89544da0288db6a0b084762e58ed3ff3 100644
--- a/ppapi/proxy/pdf_resource.h
+++ b/ppapi/proxy/pdf_resource.h
@@ -25,7 +25,7 @@ class PPAPI_PROXY_EXPORT PDFResource
public thunk::PPB_PDF_API {
public:
PDFResource(Connection connection, PP_Instance instance);
- virtual ~PDFResource();
+ ~PDFResource() override;
// For unittesting with a given locale.
void SetLocaleForTest(const std::string& locale) {
@@ -33,34 +33,34 @@ class PPAPI_PROXY_EXPORT PDFResource
}
// Resource override.
- virtual thunk::PPB_PDF_API* AsPPB_PDF_API() override;
+ thunk::PPB_PDF_API* AsPPB_PDF_API() override;
// PPB_PDF_API implementation.
PP_Var GetLocalizedString(PP_ResourceString string_id) override;
- virtual void SearchString(const unsigned short* input_string,
- const unsigned short* input_term,
- bool case_sensitive,
- PP_PrivateFindResult** results,
- int* count) override;
- virtual void DidStartLoading() override;
- virtual void DidStopLoading() override;
- virtual void SetContentRestriction(int restrictions) override;
- virtual void HistogramPDFPageCount(int count) override;
- virtual void UserMetricsRecordAction(const PP_Var& action) override;
- virtual void HasUnsupportedFeature() override;
- virtual void Print() override;
- virtual void SaveAs() override;
- virtual PP_Bool IsFeatureEnabled(PP_PDFFeature feature) override;
- virtual PP_Resource GetResourceImageForScale(PP_ResourceImage image_id,
- float scale) override;
- virtual PP_Resource GetResourceImage(PP_ResourceImage image_id) override;
- virtual PP_Bool IsOutOfProcess() override;
- virtual void SetSelectedText(const char* selected_text) override;
- virtual void SetLinkUnderCursor(const char* url) override;
- virtual void GetV8ExternalSnapshotData(const char** natives_data_out,
- int* natives_size_out,
- const char** snapshot_data_out,
- int* snapshot_size_out) override;
+ void SearchString(const unsigned short* input_string,
+ const unsigned short* input_term,
+ bool case_sensitive,
+ PP_PrivateFindResult** results,
+ int* count) override;
+ void DidStartLoading() override;
+ void DidStopLoading() override;
+ void SetContentRestriction(int restrictions) override;
+ void HistogramPDFPageCount(int count) override;
+ void UserMetricsRecordAction(const PP_Var& action) override;
+ void HasUnsupportedFeature() override;
+ void Print() override;
+ void SaveAs() override;
+ PP_Bool IsFeatureEnabled(PP_PDFFeature feature) override;
+ PP_Resource GetResourceImageForScale(PP_ResourceImage image_id,
+ float scale) override;
+ PP_Resource GetResourceImage(PP_ResourceImage image_id) override;
+ PP_Bool IsOutOfProcess() override;
+ void SetSelectedText(const char* selected_text) override;
+ void SetLinkUnderCursor(const char* url) override;
+ void GetV8ExternalSnapshotData(const char** natives_data_out,
+ int* natives_size_out,
+ const char** snapshot_data_out,
+ int* snapshot_size_out) override;
private:
std::string locale_;
« no previous file with comments | « ppapi/proxy/output_protection_resource.h ('k') | ppapi/proxy/platform_verification_private_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698