Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: ppapi/proxy/file_io_resource.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/file_chooser_resource.h ('k') | ppapi/proxy/file_ref_resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/file_io_resource.h
diff --git a/ppapi/proxy/file_io_resource.h b/ppapi/proxy/file_io_resource.h
index fed4cae70ac08dceab4e1dd18aeab963b30b9e92..f32879a43a778497c25f9affe4b48cdbf5d8ca62 100644
--- a/ppapi/proxy/file_io_resource.h
+++ b/ppapi/proxy/file_io_resource.h
@@ -30,44 +30,42 @@ class PPAPI_PROXY_EXPORT FileIOResource
public thunk::PPB_FileIO_API {
public:
FileIOResource(Connection connection, PP_Instance instance);
- virtual ~FileIOResource();
+ ~FileIOResource() override;
// Resource overrides.
- virtual thunk::PPB_FileIO_API* AsPPB_FileIO_API() override;
+ thunk::PPB_FileIO_API* AsPPB_FileIO_API() override;
// PPB_FileIO_API implementation.
- virtual int32_t Open(PP_Resource file_ref,
- int32_t open_flags,
- scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t Query(PP_FileInfo* info,
- scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t Touch(PP_Time last_access_time,
- PP_Time last_modified_time,
- scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t Read(int64_t offset,
- char* buffer,
- int32_t bytes_to_read,
- scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t ReadToArray(int64_t offset,
- int32_t max_read_length,
- PP_ArrayOutput* array_output,
+ int32_t Open(PP_Resource file_ref,
+ int32_t open_flags,
+ scoped_refptr<TrackedCallback> callback) override;
+ int32_t Query(PP_FileInfo* info,
+ scoped_refptr<TrackedCallback> callback) override;
+ int32_t Touch(PP_Time last_access_time,
+ PP_Time last_modified_time,
+ scoped_refptr<TrackedCallback> callback) override;
+ int32_t Read(int64_t offset,
+ char* buffer,
+ int32_t bytes_to_read,
+ scoped_refptr<TrackedCallback> callback) override;
+ int32_t ReadToArray(int64_t offset,
+ int32_t max_read_length,
+ PP_ArrayOutput* array_output,
+ scoped_refptr<TrackedCallback> callback) override;
+ int32_t Write(int64_t offset,
+ const char* buffer,
+ int32_t bytes_to_write,
+ scoped_refptr<TrackedCallback> callback) override;
+ int32_t SetLength(int64_t length,
+ scoped_refptr<TrackedCallback> callback) override;
+ int64_t GetMaxWrittenOffset() const override;
+ int64_t GetAppendModeWriteAmount() const override;
+ void SetMaxWrittenOffset(int64_t max_written_offset) override;
+ void SetAppendModeWriteAmount(int64_t append_mode_write_amount) override;
+ int32_t Flush(scoped_refptr<TrackedCallback> callback) override;
+ void Close() override;
+ int32_t RequestOSFileHandle(PP_FileHandle* handle,
scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t Write(int64_t offset,
- const char* buffer,
- int32_t bytes_to_write,
- scoped_refptr<TrackedCallback> callback) override;
- virtual int32_t SetLength(int64_t length,
- scoped_refptr<TrackedCallback> callback) override;
- virtual int64_t GetMaxWrittenOffset() const override;
- virtual int64_t GetAppendModeWriteAmount() const override;
- virtual void SetMaxWrittenOffset(int64_t max_written_offset) override;
- virtual void SetAppendModeWriteAmount(
- int64_t append_mode_write_amount) override;
- virtual int32_t Flush(scoped_refptr<TrackedCallback> callback) override;
- virtual void Close() override;
- virtual int32_t RequestOSFileHandle(
- PP_FileHandle* handle,
- scoped_refptr<TrackedCallback> callback) override;
// FileHolder is used to guarantee that file operations will have a valid FD
// to operate on, even if they're in a different thread.
« no previous file with comments | « ppapi/proxy/file_chooser_resource.h ('k') | ppapi/proxy/file_ref_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698