Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: ppapi/shared_impl/var.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/shared_impl/thread_aware_callback_unittest.cc ('k') | ppapi/shared_impl/var_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/var.h
diff --git a/ppapi/shared_impl/var.h b/ppapi/shared_impl/var.h
index 67b0e3a0706d6153c80de4ee51ae497ea88a0ab1..5e46864fb2ad02e690441b480c7f37b7ef90f5cc 100644
--- a/ppapi/shared_impl/var.h
+++ b/ppapi/shared_impl/var.h
@@ -101,7 +101,7 @@ class PPAPI_SHARED_EXPORT StringVar : public Var {
public:
explicit StringVar(const std::string& str);
StringVar(const char* str, uint32 len);
- virtual ~StringVar();
+ ~StringVar() override;
const std::string& value() const { return value_; }
// Return a pointer to the internal string. This allows other objects to
@@ -112,8 +112,8 @@ class PPAPI_SHARED_EXPORT StringVar : public Var {
const std::string* ptr() const { return &value_; }
// Var override.
- virtual StringVar* AsStringVar() override;
- virtual PP_VarType GetType() const override;
+ StringVar* AsStringVar() override;
+ PP_VarType GetType() const override;
// Helper function to create a PP_Var of type string that contains a copy of
// the given string. The input data must be valid UTF-8 encoded text, if it
@@ -158,7 +158,7 @@ class PPAPI_SHARED_EXPORT StringVar : public Var {
class PPAPI_SHARED_EXPORT ArrayBufferVar : public Var {
public:
ArrayBufferVar();
- virtual ~ArrayBufferVar();
+ ~ArrayBufferVar() override;
virtual void* Map() = 0;
virtual void Unmap() = 0;
@@ -176,8 +176,8 @@ class PPAPI_SHARED_EXPORT ArrayBufferVar : public Var {
base::SharedMemoryHandle* plugin_shm_handle) = 0;
// Var override.
- virtual ArrayBufferVar* AsArrayBufferVar() override;
- virtual PP_VarType GetType() const override;
+ ArrayBufferVar* AsArrayBufferVar() override;
+ PP_VarType GetType() const override;
// Helper function that converts a PP_Var to an ArrayBufferVar. This will
// return NULL if the PP_Var is not of ArrayBuffer type.
« no previous file with comments | « ppapi/shared_impl/thread_aware_callback_unittest.cc ('k') | ppapi/shared_impl/var_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698