Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: ppapi/proxy/plugin_resource.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/plugin_message_filter.h ('k') | ppapi/proxy/plugin_resource_callback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/plugin_resource.h
diff --git a/ppapi/proxy/plugin_resource.h b/ppapi/proxy/plugin_resource.h
index fd905cfe75a88faa752259c292fe0dba8585f1aa..0f2124035bcc5e8644246b476d7362c8df8ead4f 100644
--- a/ppapi/proxy/plugin_resource.h
+++ b/ppapi/proxy/plugin_resource.h
@@ -34,7 +34,7 @@ class PPAPI_PROXY_EXPORT PluginResource : public Resource {
};
PluginResource(Connection connection, PP_Instance instance);
- virtual ~PluginResource();
+ ~PluginResource() override;
// Returns true if we've previously sent a create message to the browser
// or renderer. Generally resources will use these to tell if they should
@@ -45,16 +45,15 @@ class PPAPI_PROXY_EXPORT PluginResource : public Resource {
// This handles a reply to a resource call. It works by looking up the
// callback that was registered when CallBrowser/CallRenderer was called
// and calling it with |params| and |msg|.
- virtual void OnReplyReceived(const proxy::ResourceMessageReplyParams& params,
- const IPC::Message& msg) override;
+ void OnReplyReceived(const proxy::ResourceMessageReplyParams& params,
+ const IPC::Message& msg) override;
// Resource overrides.
// Note: Subclasses shouldn't override these methods directly. Instead, they
// should implement LastPluginRefWasDeleted() or InstanceWasDeleted() to get
// notified.
- virtual void NotifyLastPluginRefWasDeleted() override;
- virtual void NotifyInstanceWasDeleted() override;
-
+ void NotifyLastPluginRefWasDeleted() override;
+ void NotifyInstanceWasDeleted() override;
// Sends a create message to the browser or renderer for the current resource.
void SendCreate(Destination dest, const IPC::Message& msg);
« no previous file with comments | « ppapi/proxy/plugin_message_filter.h ('k') | ppapi/proxy/plugin_resource_callback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698