Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: ppapi/shared_impl/thread_aware_callback_unittest.cc

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/shared_impl/test_globals.h ('k') | ppapi/shared_impl/var.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/thread_aware_callback_unittest.cc
diff --git a/ppapi/shared_impl/thread_aware_callback_unittest.cc b/ppapi/shared_impl/thread_aware_callback_unittest.cc
index 9e9189b0668a3337eac07a8f5490d97666483e58..7081daae5652e60f7a9096778b5b3c40f25664cf 100644
--- a/ppapi/shared_impl/thread_aware_callback_unittest.cc
+++ b/ppapi/shared_impl/thread_aware_callback_unittest.cc
@@ -53,19 +53,19 @@ class ThreadAwareCallbackMultiThreadTest
: public proxy::PluginProxyMultiThreadTest {
public:
ThreadAwareCallbackMultiThreadTest() : main_thread_callback_called_(false) {}
- virtual ~ThreadAwareCallbackMultiThreadTest() {
+ ~ThreadAwareCallbackMultiThreadTest() override {
CHECK(main_thread_callback_called_);
}
// proxy::PluginProxyMultiThreadTest implementation.
- virtual void SetUpTestOnMainThread() override {
+ void SetUpTestOnMainThread() override {
ProxyAutoLock auto_lock;
main_thread_callback_.reset(
ThreadAwareCallback<CallbackFunc>::Create(&MainThreadCallbackBody));
}
- virtual void SetUpTestOnSecondaryThread() override {
+ void SetUpTestOnSecondaryThread() override {
{
ProxyAutoLock auto_lock;
main_thread_callback_->RunOnTargetThread(this);
@@ -100,17 +100,17 @@ class ThreadAwareCallbackMultiThreadTest
class ThreadAwareCallbackAbortTest : public proxy::PluginProxyMultiThreadTest {
public:
ThreadAwareCallbackAbortTest() {}
- virtual ~ThreadAwareCallbackAbortTest() {}
+ ~ThreadAwareCallbackAbortTest() override {}
// proxy::PluginProxyMultiThreadTest implementation.
- virtual void SetUpTestOnMainThread() override {
+ void SetUpTestOnMainThread() override {
ProxyAutoLock auto_lock;
main_thread_callback_.reset(
ThreadAwareCallback<CallbackFunc>::Create(&MainThreadCallbackBody));
}
- virtual void SetUpTestOnSecondaryThread() override {
+ void SetUpTestOnSecondaryThread() override {
{
ProxyAutoLock auto_lock;
main_thread_message_loop_proxy_->PostTask(
« no previous file with comments | « ppapi/shared_impl/test_globals.h ('k') | ppapi/shared_impl/var.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698