Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: ppapi/shared_impl/var_tracker_unittest.cc

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/shared_impl/var.h ('k') | ppapi/tests/test_flash_fullscreen_for_browser_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/var_tracker_unittest.cc
diff --git a/ppapi/shared_impl/var_tracker_unittest.cc b/ppapi/shared_impl/var_tracker_unittest.cc
index fb8fda38b96c62acbf7f56ab632c42ef4efc7117..9dd03b311abdc73935820549f7d23fa2ae82b149 100644
--- a/ppapi/shared_impl/var_tracker_unittest.cc
+++ b/ppapi/shared_impl/var_tracker_unittest.cc
@@ -21,15 +21,15 @@ class MockStringVar : public StringVar {
MockStringVar(const std::string& str) : StringVar(str) {
mock_var_alive_count++;
}
- virtual ~MockStringVar() { mock_var_alive_count--; }
+ ~MockStringVar() override { mock_var_alive_count--; }
bool HasValidVarID() { return GetExistingVarID() != 0; }
};
class MockObjectVar : public Var {
public:
MockObjectVar() : Var() { mock_var_alive_count++; }
- virtual ~MockObjectVar() { mock_var_alive_count--; }
- virtual PP_VarType GetType() const override { return PP_VARTYPE_OBJECT; }
+ ~MockObjectVar() override { mock_var_alive_count--; }
+ PP_VarType GetType() const override { return PP_VARTYPE_OBJECT; }
bool HasValidVarID() { return GetExistingVarID() != 0; }
};
@@ -40,10 +40,10 @@ class VarTrackerTest : public testing::Test {
VarTrackerTest() {}
// Test implementation.
- virtual void SetUp() override {
+ void SetUp() override {
ASSERT_EQ(0, mock_var_alive_count);
}
- virtual void TearDown() override {}
+ void TearDown() override {}
VarTracker& var_tracker() { return *globals_.GetVarTracker(); }
« no previous file with comments | « ppapi/shared_impl/var.h ('k') | ppapi/tests/test_flash_fullscreen_for_browser_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698