Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: ppapi/proxy/ppb_message_loop_proxy.h

Issue 1097393007: Update {virtual,override} to follow C++11 style in ppapi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split off one file into separate review. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/proxy/ppb_image_data_proxy.h ('k') | ppapi/proxy/ppb_video_decoder_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PPAPI_PROXY_PPB_MESSAGE_LOOP_PROXY_H_ 5 #ifndef PPAPI_PROXY_PPB_MESSAGE_LOOP_PROXY_H_
6 #define PPAPI_PROXY_PPB_MESSAGE_LOOP_PROXY_H_ 6 #define PPAPI_PROXY_PPB_MESSAGE_LOOP_PROXY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "base/message_loop/message_loop.h" 12 #include "base/message_loop/message_loop.h"
13 #include "ppapi/proxy/interface_proxy.h" 13 #include "ppapi/proxy/interface_proxy.h"
14 #include "ppapi/proxy/ppapi_proxy_export.h" 14 #include "ppapi/proxy/ppapi_proxy_export.h"
15 #include "ppapi/shared_impl/ppb_message_loop_shared.h" 15 #include "ppapi/shared_impl/ppb_message_loop_shared.h"
16 #include "ppapi/thunk/ppb_message_loop_api.h" 16 #include "ppapi/thunk/ppb_message_loop_api.h"
17 17
18 struct PPB_MessageLoop_1_0; 18 struct PPB_MessageLoop_1_0;
19 19
20 namespace ppapi { 20 namespace ppapi {
21 namespace proxy { 21 namespace proxy {
22 22
23 class PPAPI_PROXY_EXPORT MessageLoopResource : public MessageLoopShared { 23 class PPAPI_PROXY_EXPORT MessageLoopResource : public MessageLoopShared {
24 public: 24 public:
25 explicit MessageLoopResource(PP_Instance instance); 25 explicit MessageLoopResource(PP_Instance instance);
26 // Construct the one MessageLoopResource for the main thread. This must be 26 // Construct the one MessageLoopResource for the main thread. This must be
27 // invoked on the main thread. 27 // invoked on the main thread.
28 explicit MessageLoopResource(ForMainThread); 28 explicit MessageLoopResource(ForMainThread);
29 virtual ~MessageLoopResource(); 29 ~MessageLoopResource() override;
30 30
31 // Resource overrides. 31 // Resource overrides.
32 virtual thunk::PPB_MessageLoop_API* AsPPB_MessageLoop_API() override; 32 thunk::PPB_MessageLoop_API* AsPPB_MessageLoop_API() override;
33 33
34 // PPB_MessageLoop_API implementation. 34 // PPB_MessageLoop_API implementation.
35 virtual int32_t AttachToCurrentThread() override; 35 int32_t AttachToCurrentThread() override;
36 virtual int32_t Run() override; 36 int32_t Run() override;
37 virtual int32_t PostWork(PP_CompletionCallback callback, 37 int32_t PostWork(PP_CompletionCallback callback, int64_t delay_ms) override;
38 int64_t delay_ms) override; 38 int32_t PostQuit(PP_Bool should_destroy) override;
39 virtual int32_t PostQuit(PP_Bool should_destroy) override;
40 39
41 static MessageLoopResource* GetCurrent(); 40 static MessageLoopResource* GetCurrent();
42 void DetachFromThread(); 41 void DetachFromThread();
43 bool is_main_thread_loop() const { 42 bool is_main_thread_loop() const {
44 return is_main_thread_loop_; 43 return is_main_thread_loop_;
45 } 44 }
46 45
47 const scoped_refptr<base::MessageLoopProxy>& message_loop_proxy() { 46 const scoped_refptr<base::MessageLoopProxy>& message_loop_proxy() {
48 return loop_proxy_; 47 return loop_proxy_;
49 } 48 }
(...skipping 12 matching lines...) Expand all
62 // Returns true if the object is associated with the current thread. 61 // Returns true if the object is associated with the current thread.
63 bool IsCurrent() const; 62 bool IsCurrent() const;
64 63
65 // MessageLoopShared implementation. 64 // MessageLoopShared implementation.
66 // 65 //
67 // Handles posting to the message loop if there is one, or the pending queue 66 // Handles posting to the message loop if there is one, or the pending queue
68 // if there isn't. 67 // if there isn't.
69 // NOTE: The given closure will be run *WITHOUT* acquiring the Proxy lock. 68 // NOTE: The given closure will be run *WITHOUT* acquiring the Proxy lock.
70 // This only makes sense for user code and completely thread-safe 69 // This only makes sense for user code and completely thread-safe
71 // proxy operations (e.g., MessageLoop::QuitClosure). 70 // proxy operations (e.g., MessageLoop::QuitClosure).
72 virtual void PostClosure(const tracked_objects::Location& from_here, 71 void PostClosure(const tracked_objects::Location& from_here,
73 const base::Closure& closure, 72 const base::Closure& closure,
74 int64 delay_ms) override; 73 int64 delay_ms) override;
75 virtual base::MessageLoopProxy* GetMessageLoopProxy() override; 74 base::MessageLoopProxy* GetMessageLoopProxy() override;
76 virtual bool CurrentlyHandlingBlockingMessage() override; 75 bool CurrentlyHandlingBlockingMessage() override;
77 76
78 // TLS destructor function. 77 // TLS destructor function.
79 static void ReleaseMessageLoop(void* value); 78 static void ReleaseMessageLoop(void* value);
80 79
81 // Created when we attach to the current thread, since MessageLoop assumes 80 // Created when we attach to the current thread, since MessageLoop assumes
82 // that it's created on the thread it will run on. NULL for the main thread 81 // that it's created on the thread it will run on. NULL for the main thread
83 // loop, since that's owned by somebody else. This is needed for Run and Quit. 82 // loop, since that's owned by somebody else. This is needed for Run and Quit.
84 // Any time we post tasks, we should post them using loop_proxy_. 83 // Any time we post tasks, we should post them using loop_proxy_.
85 scoped_ptr<base::MessageLoop> loop_; 84 scoped_ptr<base::MessageLoop> loop_;
86 scoped_refptr<base::MessageLoopProxy> loop_proxy_; 85 scoped_refptr<base::MessageLoopProxy> loop_proxy_;
(...skipping 29 matching lines...) Expand all
116 static const PPB_MessageLoop_1_0* GetInterface(); 115 static const PPB_MessageLoop_1_0* GetInterface();
117 116
118 private: 117 private:
119 DISALLOW_COPY_AND_ASSIGN(PPB_MessageLoop_Proxy); 118 DISALLOW_COPY_AND_ASSIGN(PPB_MessageLoop_Proxy);
120 }; 119 };
121 120
122 } // namespace proxy 121 } // namespace proxy
123 } // namespace ppapi 122 } // namespace ppapi
124 123
125 #endif // PPAPI_PROXY_PPB_MESSAGE_LOOP_PROXY_H_ 124 #endif // PPAPI_PROXY_PPB_MESSAGE_LOOP_PROXY_H_
OLDNEW
« no previous file with comments | « ppapi/proxy/ppb_image_data_proxy.h ('k') | ppapi/proxy/ppb_video_decoder_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698