Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
bsalomon, sky, reed1
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, zea+watch_chromium.org, tfarina, mlamouri+watch-notifications_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, pvalenzuela+watch_chromium.org, noyau+watch_chromium.org, estade+watch_chromium.org, dbeam+watch-ntp_chromium.org, chromium-apps-reviews_chromium.org, peter+watch_chromium.org, pedrosimonetti+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@favicon_service
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize FaviconService and FaviconHandler Move FaviconService and FaviconHandler into //components/favicon/core/browser as they have no problematic dependencies anymore. Update DEPS and dependencies of favicon component. BUG=359514, 359513 Committed: https://crrev.com/fee69b4b384e94f03cd7d4dadf3140dd91bb9029 Cr-Commit-Position: refs/heads/master@{#320738}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix android_aosp build #

Patch Set 4 : Rebase #

Patch Set 5 : Fix android_aosp (reverted the change by mistake by switching computer) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -1742 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/favicon_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/favicon/favicon_handler.h View 1 2 3 1 chunk +0 lines, -309 lines 0 comments Download
D chrome/browser/favicon/favicon_handler.cc View 1 2 3 1 chunk +0 lines, -693 lines 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/favicon/favicon_service.h View 1 chunk +0 lines, -254 lines 0 comments Download
D chrome/browser/favicon/favicon_service.cc View 1 1 chunk +0 lines, -391 lines 0 comments Download
M chrome/browser/favicon/favicon_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/favicon/favicon_tab_helper_observer.h View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/history/android/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/profile_writer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/favicon_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/navigation_popup.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M components/components.gyp View 1 2 4 2 chunks +1 line, -1 line 0 comments Download
M components/favicon.gypi View 2 chunks +28 lines, -2 lines 0 comments Download
M components/favicon/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M components/favicon/core/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
A components/favicon/core/browser/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A components/favicon/core/browser/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A + components/favicon/core/browser/favicon_handler.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/favicon/core/browser/favicon_handler.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + components/favicon/core/browser/favicon_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/favicon/core/browser/favicon_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/favicon/core/browser/favicon_tab_helper_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
sdefresne
Please take a look.
5 years, 9 months ago (2015-03-06 17:21:26 UTC) #2
sky
LGTM
5 years, 9 months ago (2015-03-09 15:35:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983043003/20001
5 years, 9 months ago (2015-03-13 21:05:56 UTC) #6
sdefresne
reed, bsalomon: for whoever would be fastest, I need OWNERS approval for adding to favicon ...
5 years, 9 months ago (2015-03-13 21:19:44 UTC) #9
reed1
skia lgtm
5 years, 9 months ago (2015-03-16 14:19:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983043003/40001
5 years, 9 months ago (2015-03-16 14:19:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983043003/80001
5 years, 9 months ago (2015-03-16 16:51:59 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-16 16:56:13 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 16:56:52 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fee69b4b384e94f03cd7d4dadf3140dd91bb9029
Cr-Commit-Position: refs/heads/master@{#320738}

Powered by Google App Engine
This is Rietveld 408576698