chrome/browser/jumplist_win.cc - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/jumplist_win.cc

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/importer/profile_writer.cc ('k') | chrome/browser/notifications/message_center_settings_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/jumplist_win.cc

diff --git a/chrome/browser/jumplist_win.cc b/chrome/browser/jumplist_win.cc

index 010b3b14ab8682c4df97ca4852e25483fea45eb0..7745f07516323188b3e7af5fa9d4c593efe611cb 100644

--- a/chrome/browser/jumplist_win.cc

+++ b/chrome/browser/jumplist_win.cc

@@ -14,7 +14,6 @@

#include "base/strings/utf_string_conversions.h"

#include "base/threading/thread.h"

#include "chrome/browser/chrome_notification_types.h"

-#include "chrome/browser/favicon/favicon_service.h"

#include "chrome/browser/favicon/favicon_service_factory.h"

#include "chrome/browser/history/top_sites_factory.h"

#include "chrome/browser/metrics/jumplist_metrics_win.h"

@@ -27,6 +26,7 @@

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "chrome/grit/generated_resources.h"

+#include "components/favicon/core/browser/favicon_service.h"

#include "components/favicon_base/favicon_types.h"

#include "components/history/core/browser/history_service.h"

#include "components/history/core/browser/page_usage_data.h"

« no previous file with comments | « chrome/browser/importer/profile_writer.cc ('k') | chrome/browser/notifications/message_center_settings_controller.cc » ('j') | no next file with comments »