Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/history/android/android_history_provider_service.cc

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service
Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/history/android/DEPS ('k') | chrome/browser/importer/profile_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/android/android_history_provider_service.h" 5 #include "chrome/browser/history/android/android_history_provider_service.h"
6 6
7 #include "chrome/browser/favicon/favicon_service.h"
8 #include "chrome/browser/favicon/favicon_service_factory.h" 7 #include "chrome/browser/favicon/favicon_service_factory.h"
9 #include "chrome/browser/history/android/android_provider_backend.h" 8 #include "chrome/browser/history/android/android_provider_backend.h"
10 #include "chrome/browser/history/history_service_factory.h" 9 #include "chrome/browser/history/history_service_factory.h"
11 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
11 #include "components/favicon/core/browser/favicon_service.h"
12 #include "components/history/core/browser/android/android_history_types.h" 12 #include "components/history/core/browser/android/android_history_types.h"
13 #include "components/history/core/browser/history_backend.h" 13 #include "components/history/core/browser/history_backend.h"
14 #include "components/history/core/browser/history_db_task.h" 14 #include "components/history/core/browser/history_db_task.h"
15 #include "components/history/core/browser/history_service.h" 15 #include "components/history/core/browser/history_service.h"
16 16
17 namespace { 17 namespace {
18 18
19 // AndroidProviderTask wraps two callbacks into an HistoryDBTask so that they 19 // AndroidProviderTask wraps two callbacks into an HistoryDBTask so that they
20 // can be passed to HistoryService::ScheduleDBTask. ResultType must be zero 20 // can be passed to HistoryService::ScheduleDBTask. ResultType must be zero
21 // constructible (i.e. ResultType(0) should build an initialized default value) 21 // constructible (i.e. ResultType(0) should build an initialized default value)
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 base::CancelableTaskTracker::TaskId 457 base::CancelableTaskTracker::TaskId
458 AndroidHistoryProviderService::GetLargestRawFaviconForID( 458 AndroidHistoryProviderService::GetLargestRawFaviconForID(
459 favicon_base::FaviconID favicon_id, 459 favicon_base::FaviconID favicon_id,
460 const favicon_base::FaviconRawBitmapCallback& callback, 460 const favicon_base::FaviconRawBitmapCallback& callback,
461 base::CancelableTaskTracker* tracker) { 461 base::CancelableTaskTracker* tracker) {
462 FaviconService* fs = FaviconServiceFactory::GetForProfile( 462 FaviconService* fs = FaviconServiceFactory::GetForProfile(
463 profile_, ServiceAccessType::EXPLICIT_ACCESS); 463 profile_, ServiceAccessType::EXPLICIT_ACCESS);
464 DCHECK(fs); 464 DCHECK(fs);
465 return fs->GetLargestRawFaviconForID(favicon_id, callback, tracker); 465 return fs->GetLargestRawFaviconForID(favicon_id, callback, tracker);
466 } 466 }
OLDNEW
« no previous file with comments | « chrome/browser/history/android/DEPS ('k') | chrome/browser/importer/profile_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698