chrome/browser/favicon/favicon_tab_helper.cc - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/favicon/favicon_tab_helper.cc

diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc

index 180e3a7d517a67060d0bbf340536b2ad31ddfe80..d95ffd1d23bb21c3809aa1aaef2b86fb6054b8b1 100644

--- a/chrome/browser/favicon/favicon_tab_helper.cc

+++ b/chrome/browser/favicon/favicon_tab_helper.cc

@@ -7,15 +7,15 @@

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/favicon/chrome_favicon_client.h"

#include "chrome/browser/favicon/chrome_favicon_client_factory.h"

-#include "chrome/browser/favicon/favicon_handler.h"

-#include "chrome/browser/favicon/favicon_service.h"

#include "chrome/browser/favicon/favicon_service_factory.h"

-#include "chrome/browser/favicon/favicon_tab_helper_observer.h"

#include "chrome/browser/history/history_service_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search/search.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/url_constants.h"

+#include "components/favicon/core/browser/favicon_handler.h"

+#include "components/favicon/core/browser/favicon_service.h"

+#include "components/favicon/core/browser/favicon_tab_helper_observer.h"

#include "components/favicon_base/favicon_types.h"

#include "components/history/core/browser/history_service.h"

#include "content/public/browser/favicon_status.h"

« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.cc ('k') | chrome/browser/favicon/favicon_tab_helper_browsertest.cc » ('j') | no next file with comments »