Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: chrome/browser/bookmarks/bookmark_html_writer.cc

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service
Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_html_writer.h" 5 #include "chrome/browser/bookmarks/bookmark_html_writer.h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/files/file.h" 11 #include "base/files/file.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/message_loop/message_loop.h" 13 #include "base/message_loop/message_loop.h"
14 #include "base/strings/string_number_conversions.h" 14 #include "base/strings/string_number_conversions.h"
15 #include "base/strings/string_util.h" 15 #include "base/strings/string_util.h"
16 #include "base/time/time.h" 16 #include "base/time/time.h"
17 #include "base/values.h" 17 #include "base/values.h"
18 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 18 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
19 #include "chrome/browser/chrome_notification_types.h" 19 #include "chrome/browser/chrome_notification_types.h"
20 #include "chrome/browser/favicon/favicon_service.h"
21 #include "chrome/browser/favicon/favicon_service_factory.h" 20 #include "chrome/browser/favicon/favicon_service_factory.h"
22 #include "components/bookmarks/browser/bookmark_codec.h" 21 #include "components/bookmarks/browser/bookmark_codec.h"
23 #include "components/bookmarks/browser/bookmark_model.h" 22 #include "components/bookmarks/browser/bookmark_model.h"
23 #include "components/favicon/core/browser/favicon_service.h"
24 #include "components/favicon_base/favicon_types.h" 24 #include "components/favicon_base/favicon_types.h"
25 #include "content/public/browser/browser_thread.h" 25 #include "content/public/browser/browser_thread.h"
26 #include "content/public/browser/notification_source.h" 26 #include "content/public/browser/notification_source.h"
27 #include "grit/components_strings.h" 27 #include "grit/components_strings.h"
28 #include "net/base/escape.h" 28 #include "net/base/escape.h"
29 #include "ui/base/l10n/l10n_util.h" 29 #include "ui/base/l10n/l10n_util.h"
30 #include "ui/gfx/favicon_size.h" 30 #include "ui/gfx/favicon_size.h"
31 31
32 using bookmarks::BookmarkCodec; 32 using bookmarks::BookmarkCodec;
33 using bookmarks::BookmarkNode; 33 using bookmarks::BookmarkNode;
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 // BookmarkModel isn't thread safe (nor would we want to lock it down 501 // BookmarkModel isn't thread safe (nor would we want to lock it down
502 // for the duration of the write), as such we make a copy of the 502 // for the duration of the write), as such we make a copy of the
503 // BookmarkModel using BookmarkCodec then write from that. 503 // BookmarkModel using BookmarkCodec then write from that.
504 if (fetcher == NULL) { 504 if (fetcher == NULL) {
505 fetcher = new BookmarkFaviconFetcher(profile, path, observer); 505 fetcher = new BookmarkFaviconFetcher(profile, path, observer);
506 fetcher->ExportBookmarks(); 506 fetcher->ExportBookmarks();
507 } 507 }
508 } 508 }
509 509
510 } // namespace bookmark_html_writer 510 } // namespace bookmark_html_writer
OLDNEW
« no previous file with comments | « chrome/browser/android/tab_android.h ('k') | chrome/browser/bookmarks/bookmark_html_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698