chrome/browser/favicon/favicon_tab_helper_browsertest.cc - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper_browsertest.cc

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/favicon/favicon_tab_helper_browsertest.cc

diff --git a/chrome/browser/favicon/favicon_tab_helper_browsertest.cc b/chrome/browser/favicon/favicon_tab_helper_browsertest.cc

index e5facb74e706c7934a7fb7ba540f7b2ebf92582b..81bd22653b422e9d0dfcd90bd388cdcb6bc5e4e1 100644

--- a/chrome/browser/favicon/favicon_tab_helper_browsertest.cc

+++ b/chrome/browser/favicon/favicon_tab_helper_browsertest.cc

@@ -8,12 +8,12 @@

#include "base/run_loop.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/chrome_notification_types.h"

-#include "chrome/browser/favicon/favicon_handler.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/ui_test_utils.h"

+#include "components/favicon/core/browser/favicon_handler.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "content/public/browser/notification_types.h"

« no previous file with comments | « chrome/browser/favicon/favicon_tab_helper.cc ('k') | chrome/browser/favicon/favicon_tab_helper_observer.h » ('j') | no next file with comments »