chrome/browser/bookmarks/chrome_bookmark_client.cc - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/chrome_bookmark_client.cc

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer_unittest.cc ('k') | chrome/browser/extensions/api/management/chrome_management_api_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/chrome_bookmark_client.cc

diff --git a/chrome/browser/bookmarks/chrome_bookmark_client.cc b/chrome/browser/bookmarks/chrome_bookmark_client.cc

index 863000ef488ed880ffb7f7cbadca68ae973fc7f5..14e2f1a8aed6e74774695299c11cf4eb1f4b990e 100644

--- a/chrome/browser/bookmarks/chrome_bookmark_client.cc

+++ b/chrome/browser/bookmarks/chrome_bookmark_client.cc

@@ -8,7 +8,6 @@

#include "base/bind_helpers.h"

#include "base/logging.h"

#include "base/values.h"

-#include "chrome/browser/favicon/favicon_service.h"

#include "chrome/browser/favicon/favicon_service_factory.h"

#include "chrome/browser/policy/profile_policy_connector.h"

#include "chrome/browser/policy/profile_policy_connector_factory.h"

@@ -16,6 +15,7 @@

#include "components/bookmarks/browser/bookmark_model.h"

#include "components/bookmarks/browser/bookmark_node.h"

#include "components/bookmarks/browser/bookmark_utils.h"

+#include "components/favicon/core/browser/favicon_service.h"

#include "components/history/core/browser/history_service.h"

#include "components/history/core/browser/url_database.h"

#include "content/public/browser/browser_thread.h"