components/favicon/core/BUILD.gn - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/BUILD.gn

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon/core/BUILD.gn

diff --git a/components/favicon/core/BUILD.gn b/components/favicon/core/BUILD.gn

index 0f834cb1d8538adcac7c91f4c4ab32260d29539e..05bd40bf35b29d1ebf4cd07eed81cf54eb3bbfdf 100644

--- a/components/favicon/core/BUILD.gn

+++ b/components/favicon/core/BUILD.gn

@@ -4,7 +4,6 @@

static_library("core") {

sources = [

- "browser/favicon_client.h",

"favicon_driver.h",

"favicon_url.cc",

"favicon_url.h",

@@ -12,7 +11,7 @@ static_library("core") {

deps = [

"//components/favicon_base",

- "//components/keyed_service/core",

"//ui/gfx/geometry",

+ "//url",

]

}

« no previous file with comments | « components/favicon/DEPS ('k') | components/favicon/core/browser/BUILD.gn » ('j') | no next file with comments »