chrome/browser/android/shortcut_helper.cc - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_helper.cc

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/shortcut_helper.cc

diff --git a/chrome/browser/android/shortcut_helper.cc b/chrome/browser/android/shortcut_helper.cc

index 00b9e36ae2622761e127dbb1609478d8fbf887c9..f1f0bf82fbb45411a4bebdcee125ec8bcc11d366 100644

--- a/chrome/browser/android/shortcut_helper.cc

+++ b/chrome/browser/android/shortcut_helper.cc

@@ -16,7 +16,6 @@

#include "base/task/cancelable_task_tracker.h"

#include "base/threading/worker_pool.h"

#include "chrome/browser/banners/app_banner_settings_helper.h"

-#include "chrome/browser/favicon/favicon_service.h"

#include "chrome/browser/favicon/favicon_service_factory.h"

#include "chrome/browser/manifest/manifest_icon_selector.h"

#include "chrome/browser/profiles/profile.h"

@@ -24,6 +23,7 @@

#include "chrome/common/render_messages.h"

#include "chrome/common/web_application_info.h"

#include "components/dom_distiller/core/url_utils.h"

+#include "components/favicon/core/browser/favicon_service.h"

#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_observer.h"

« no previous file with comments | « chrome/browser/android/provider/chrome_browser_provider.cc ('k') | chrome/browser/android/tab_android.h » ('j') | no next file with comments »