components/BUILD.gn - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/BUILD.gn

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/BUILD.gn

diff --git a/components/BUILD.gn b/components/BUILD.gn

index 12e023ab0646cc6872dfa8ae9d4f2fd69056006f..ed5b887d6a8254196c05a927988f311d443aa253 100644

--- a/components/BUILD.gn

+++ b/components/BUILD.gn

@@ -38,7 +38,7 @@ group("all_components") {

"//components/dom_distiller/core",

"//components/domain_reliability",

"//components/enhanced_bookmarks",

- "//components/favicon/core",

+ "//components/favicon/core/browser",

"//components/favicon_base",

"//components/feedback",

"//components/gcm_driver",

@@ -162,8 +162,9 @@ group("all_components") {

"//components/data_reduction_proxy/core/common", # Should work, needs checking.

"//components/dom_distiller/core", # Blocked on content.

"//components/domain_reliability", # Blocked on content.

+ "//components/favicon/core/browser", # Blocked on keyed service.

"//components/favicon_base", # Should work, needs checking.

- "//components/favicon/core", # Blocked on keyed service.

+ "//components/feedback", # Blocked on content.

"//components/gcm_driver", # Should work, needs checking.

"//components/google/core/browser", # Should work, needs checking.

"//components/history/core/browser", # Should work, needs checking.

« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/components.gyp » ('j') | no next file with comments »