Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: components/favicon.gypi

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service
Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/components.gyp ('k') | components/favicon/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/favicon/core 8 # GN version: //components/favicon/core
9 'target_name': 'favicon_core', 9 'target_name': 'favicon_core',
10 'type': 'static_library', 10 'type': 'static_library',
11 'dependencies': [ 11 'dependencies': [
12 '../ui/gfx/gfx.gyp:gfx_geometry', 12 '../ui/gfx/gfx.gyp:gfx_geometry',
13 '../url/url.gyp:url_lib',
13 'favicon_base', 14 'favicon_base',
14 'keyed_service_core',
15 ], 15 ],
16 'sources': [ 16 'sources': [
17 # Note: sources list duplicated in GN build. 17 # Note: sources list duplicated in GN build.
18 'favicon/core/browser/favicon_client.h',
19 'favicon/core/favicon_driver.h', 18 'favicon/core/favicon_driver.h',
20 'favicon/core/favicon_url.cc', 19 'favicon/core/favicon_url.cc',
21 'favicon/core/favicon_url.h', 20 'favicon/core/favicon_url.h',
22 ], 21 ],
23 'include_dirs': [ 22 'include_dirs': [
24 '..', 23 '..',
25 ], 24 ],
26 }, 25 },
26 {
27 # GN version: //components/favicon/core/browser
28 'target_name': 'favicon_core_browser',
29 'type': 'static_library',
30 'dependencies': [
31 '../skia/skia.gyp:skia',
32 '../ui/gfx/gfx.gyp:gfx',
33 '../url/url.gyp:url_lib',
34 'bookmarks_browser',
35 'favicon_base',
36 'favicon_core',
37 'history_core_browser',
38 'keyed_service_core',
39 ],
40 'sources': [
41 # Note: sources list duplicated in GN build.
42 'favicon/core/browser/favicon_client.h',
43 'favicon/core/browser/favicon_handler.cc',
44 'favicon/core/browser/favicon_handler.h',
45 'favicon/core/browser/favicon_service.cc',
46 'favicon/core/browser/favicon_service.h',
47 'favicon/core/browser/favicon_tab_helper_observer.h',
48 ],
49 'include_dirs': [
50 '..',
51 ],
52 },
27 ], 53 ],
28 } 54 }
OLDNEW
« no previous file with comments | « components/components.gyp ('k') | components/favicon/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698