chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc ('k') | chrome/browser/ui/cocoa/history_menu_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

diff --git a/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc b/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

index d7668c539cf7f3c9de319c185be7acc3a1709185..6535b14efd902ef5caa54ac5eb9f9e7b23fe706b 100644

--- a/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

+++ b/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

@@ -5,10 +5,10 @@

#include "chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.h"

#include "base/strings/utf_string_conversions.h"

-#include "chrome/browser/favicon/favicon_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"

#include "chrome/browser/ui/app_list/search/search_util.h"

+#include "components/favicon/core/browser/favicon_service.h"

#include "components/favicon_base/favicon_callback.h"

#include "components/favicon_base/favicon_types.h"

#include "components/suggestions/suggestions_service.h"