chrome/browser/sync/glue/bookmark_change_processor.cc - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/bookmark_change_processor.cc

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_settings_controller.cc ('k') | chrome/browser/sync/glue/favicon_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/bookmark_change_processor.cc

diff --git a/chrome/browser/sync/glue/bookmark_change_processor.cc b/chrome/browser/sync/glue/bookmark_change_processor.cc

index cc110dfb06aa8979467202d1da8e7ce6f1b0d92e..cc6340f2e74a8e58cdc17e64a3d1777d40f5f9a1 100644

--- a/chrome/browser/sync/glue/bookmark_change_processor.cc

+++ b/chrome/browser/sync/glue/bookmark_change_processor.cc

@@ -14,7 +14,6 @@

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

-#include "chrome/browser/favicon/favicon_service.h"

#include "chrome/browser/favicon/favicon_service_factory.h"

#include "chrome/browser/history/history_service_factory.h"

#include "chrome/browser/profiles/profile.h"

@@ -25,6 +24,7 @@

#include "components/bookmarks/browser/bookmark_client.h"

#include "components/bookmarks/browser/bookmark_model.h"

#include "components/bookmarks/browser/bookmark_utils.h"

+#include "components/favicon/core/browser/favicon_service.h"

#include "components/history/core/browser/history_service.h"

#include "content/public/browser/browser_thread.h"

#include "sync/internal_api/public/change_record.h"

« no previous file with comments | « chrome/browser/notifications/message_center_settings_controller.cc ('k') | chrome/browser/sync/glue/favicon_cache.cc » ('j') | no next file with comments »