components/components.gyp - Issue 983043003: Componentize FaviconService and FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/components.gyp

Issue 983043003: Componentize FaviconService and FaviconHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_service

Patch Set: Fix android_aosp (reverted the change by mistake by switching computer) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/components.gyp

diff --git a/components/components.gyp b/components/components.gyp

index bbf257196caec8df27b23c0264c3f8050f69cc1f..5160960f628f199cdf922fe93e2e65739320bbb7 100644

--- a/components/components.gyp

+++ b/components/components.gyp

@@ -27,7 +27,6 @@

'domain_reliability.gypi',

'enhanced_bookmarks.gypi',

'error_page.gypi',

- 'favicon.gypi',

'favicon_base.gypi',

'feedback.gypi',

'google.gypi',

@@ -129,6 +128,7 @@

# Android WebView fails to build if a dependency on these targets is

# introduced.

'includes': [

+ 'favicon.gypi',

'gcm_driver.gypi',

'history.gypi',

'omnibox.gypi',

« no previous file with comments | « components/BUILD.gn ('k') | components/favicon.gypi » ('j') | no next file with comments »