Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 777443003: Move shader precision out of GrShaderVar (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@prec
Visibility:
Public.

Description

Move shader precision out of GrShaderVar Committed: https://skia.googlesource.com/skia/+/c0bd6484f621e4a1033be318b1947a5d32157c13

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -83 lines) Patch
M include/gpu/GrCoordTransform.h View 4 chunks +4 lines, -4 lines 0 comments Download
M include/gpu/GrShaderVar.h View 9 chunks +11 lines, -24 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/gpu/GrCoordTransform.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 7 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bsalomon
Requires 778783002 to land. GrShaderVar.h and GrTypesPriv.h are the (barely) substantive change, the rest is ...
6 years ago (2014-12-08 22:23:22 UTC) #2
joshualitt
On 2014/12/08 22:23:22, bsalomon wrote: > Requires 778783002 to land. GrShaderVar.h and GrTypesPriv.h are the ...
6 years ago (2014-12-09 14:52:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777443003/20001
6 years ago (2014-12-09 17:44:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1399)
6 years ago (2014-12-09 17:48:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777443003/20001
6 years ago (2014-12-09 17:57:34 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-09 18:04:20 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c0bd6484f621e4a1033be318b1947a5d32157c13

Powered by Google App Engine
This is Rietveld 408576698