Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@writingmode
Project:
mojo
Visibility:
Public.

Description

Remove all writing mode function arguments and remove writing mode from RenderStyle. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/81206245a7ad7b02077c6bdd11e089755f596908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -233 lines) Patch
M sky/engine/build/scripts/templates/StyleBuilder.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSProperty.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSProperty.cpp View 3 chunks +33 lines, -33 lines 0 comments Download
M sky/engine/core/css/resolver/MatchedPropertiesCache.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResolverState.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 2 chunks +11 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderGrid.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/shapes/Shape.h View 2 chunks +4 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/shapes/Shape.cpp View 7 chunks +21 lines, -25 lines 0 comments Download
M sky/engine/core/rendering/shapes/ShapeOutsideInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp View 6 chunks +10 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 8 chunks +20 lines, -38 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/platform/LengthBox.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/engine/platform/LengthBox.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M sky/engine/platform/geometry/LayoutBoxExtent.h View 1 chunk +16 lines, -16 lines 0 comments Download
M sky/engine/platform/geometry/LayoutBoxExtent.cpp View 3 chunks +32 lines, -32 lines 0 comments Download
M sky/engine/platform/text/WritingMode.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
This depends on https://codereview.chromium.org/689743002.
6 years, 1 month ago (2014-10-29 19:12:11 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-10-29 19:15:55 UTC) #3
ojan
6 years, 1 month ago (2014-10-29 19:18:35 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
81206245a7ad7b02077c6bdd11e089755f596908.

Powered by Google App Engine
This is Rietveld 408576698