sky/engine/core/css/resolver/MatchedPropertiesCache.cpp - Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/resolver/MatchedPropertiesCache.cpp

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/css/resolver/MatchedPropertiesCache.cpp

diff --git a/sky/engine/core/css/resolver/MatchedPropertiesCache.cpp b/sky/engine/core/css/resolver/MatchedPropertiesCache.cpp

index a3739d3847707cf0f0e33aed867c88f69a2f61c6..3a4ef10a54a843085d37aae1103f47a17c3b6eec 100644

--- a/sky/engine/core/css/resolver/MatchedPropertiesCache.cpp

+++ b/sky/engine/core/css/resolver/MatchedPropertiesCache.cpp

@@ -144,8 +144,6 @@ bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty

return false;

if (style->zoom() != RenderStyle::initialZoom())

return false;

- if (style->writingMode() != RenderStyle::initialWritingMode())

- return false;

if (style->hasCurrentColor())

return false;

// The cache assumes static knowledge about which properties are inherited.

« no previous file with comments | « sky/engine/core/css/CSSProperty.cpp ('k') | sky/engine/core/css/resolver/StyleAdjuster.cpp » ('j') | no next file with comments »