Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Side by Side Diff: sky/engine/core/css/resolver/StyleResolverState.h

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/css/resolver/StyleResolver.cpp ('k') | sky/engine/core/dom/Document.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 94
95 FontBuilder& fontBuilder() { return m_fontBuilder; } 95 FontBuilder& fontBuilder() { return m_fontBuilder; }
96 // FIXME: These exist as a primitive way to track mutations to font-related properties 96 // FIXME: These exist as a primitive way to track mutations to font-related properties
97 // on a RenderStyle. As designed, these are very error-prone, as some caller s 97 // on a RenderStyle. As designed, these are very error-prone, as some caller s
98 // set these directly on the RenderStyle w/o telling us. Presumably we'll 98 // set these directly on the RenderStyle w/o telling us. Presumably we'll
99 // want to design a better wrapper around RenderStyle for tracking these mut ations 99 // want to design a better wrapper around RenderStyle for tracking these mut ations
100 // and separate it from StyleResolverState. 100 // and separate it from StyleResolverState.
101 const FontDescription& parentFontDescription() { return m_parentStyle->fontD escription(); } 101 const FontDescription& parentFontDescription() { return m_parentStyle->fontD escription(); }
102 void setZoom(float f) { m_fontBuilder.didChangeFontParameters(m_style->setZo om(f)); } 102 void setZoom(float f) { m_fontBuilder.didChangeFontParameters(m_style->setZo om(f)); }
103 void setEffectiveZoom(float f) { m_fontBuilder.didChangeFontParameters(m_sty le->setEffectiveZoom(f)); } 103 void setEffectiveZoom(float f) { m_fontBuilder.didChangeFontParameters(m_sty le->setEffectiveZoom(f)); }
104 void setWritingMode(WritingMode writingMode) { m_fontBuilder.didChangeFontPa rameters(m_style->setWritingMode(writingMode)); }
105 void setTextOrientation(TextOrientation textOrientation) { m_fontBuilder.did ChangeFontParameters(m_style->setTextOrientation(textOrientation)); } 104 void setTextOrientation(TextOrientation textOrientation) { m_fontBuilder.did ChangeFontParameters(m_style->setTextOrientation(textOrientation)); }
106 105
107 private: 106 private:
108 ElementResolveContext m_elementContext; 107 ElementResolveContext m_elementContext;
109 RawPtr<Document> m_document; 108 RawPtr<Document> m_document;
110 109
111 // m_style is the primary output for each element's style resolve. 110 // m_style is the primary output for each element's style resolve.
112 RefPtr<RenderStyle> m_style; 111 RefPtr<RenderStyle> m_style;
113 112
114 CSSToLengthConversionData m_cssToLengthConversionData; 113 CSSToLengthConversionData m_cssToLengthConversionData;
(...skipping 11 matching lines...) Expand all
126 ElementStyleResources m_elementStyleResources; 125 ElementStyleResources m_elementStyleResources;
127 // CSSToStyleMap is a pure-logic class and only contains 126 // CSSToStyleMap is a pure-logic class and only contains
128 // a back-pointer to this object. 127 // a back-pointer to this object.
129 CSSToStyleMap m_styleMap; 128 CSSToStyleMap m_styleMap;
130 Vector<AtomicString> m_contentAttrValues; 129 Vector<AtomicString> m_contentAttrValues;
131 }; 130 };
132 131
133 } // namespace blink 132 } // namespace blink
134 133
135 #endif // StyleResolverState_h 134 #endif // StyleResolverState_h
OLDNEW
« no previous file with comments | « sky/engine/core/css/resolver/StyleResolver.cpp ('k') | sky/engine/core/dom/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698