Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 689743002: First past at removing writing mode. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

First past at removing writing mode. This removes the parsing and the enum. This leaves a bunch of dead code around to fix in a followup. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bc1984c5ec6b73c17ad0f6fb391405dbd9f77116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -416 lines) Patch
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -40 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSProperty.cpp View 1 chunk +13 lines, -97 lines 0 comments Download
M sky/engine/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/FontBuilder.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/css/resolver/MatchedPropertiesCache.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 2 chunks +2 lines, -26 lines 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.cpp View 5 chunks +7 lines, -69 lines 0 comments Download
M sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp View 1 chunk +2 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 2 chunks +4 lines, -44 lines 0 comments Download
M sky/engine/platform/LengthBox.cpp View 1 chunk +2 lines, -22 lines 0 comments Download
M sky/engine/platform/geometry/LayoutBoxExtent.cpp View 2 chunks +6 lines, -56 lines 0 comments Download
M sky/engine/platform/text/WritingMode.h View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
6 years, 1 month ago (2014-10-29 18:38:15 UTC) #1
esprehn
You also removed a ton of RTL code here, I don't think you wanted to ...
6 years, 1 month ago (2014-10-29 19:10:45 UTC) #3
esprehn
lgtm
6 years, 1 month ago (2014-10-29 19:15:11 UTC) #4
ojan
6 years, 1 month ago (2014-10-29 19:17:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
bc1984c5ec6b73c17ad0f6fb391405dbd9f77116.

Powered by Google App Engine
This is Rietveld 408576698