sky/engine/build/scripts/templates/StyleBuilder.cpp.tmpl - Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/build/scripts/templates/StyleBuilder.cpp.tmpl

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/build/scripts/templates/StyleBuilder.cpp.tmpl

diff --git a/sky/engine/build/scripts/templates/StyleBuilder.cpp.tmpl b/sky/engine/build/scripts/templates/StyleBuilder.cpp.tmpl

index 537baf0b6fbde46856c5466803673ba1d85315a2..12d5ba415a0da98a63beb7505e766fe24bc03316 100644

--- a/sky/engine/build/scripts/templates/StyleBuilder.cpp.tmpl

+++ b/sky/engine/build/scripts/templates/StyleBuilder.cpp.tmpl

@@ -33,7 +33,7 @@ void StyleBuilder::applyProperty(CSSPropertyID property, StyleResolverState& sta

case {{property_id}}:

{% endfor %}

{

- CSSPropertyID resolvedProperty = CSSProperty::resolveDirectionAwareProperty(property, state.style()->direction(), state.style()->writingMode());

+ CSSPropertyID resolvedProperty = CSSProperty::resolveDirectionAwareProperty(property, state.style()->direction());

ASSERT(resolvedProperty != property);

applyProperty(resolvedProperty, state, value);

return;

« no previous file with comments | « no previous file | sky/engine/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »