Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: sky/engine/core/css/resolver/MatchedPropertiesCache.cpp

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/css/CSSProperty.cpp ('k') | sky/engine/core/css/resolver/StyleAdjuster.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 m_cache.removeAll(toRemove); 137 m_cache.removeAll(toRemove);
138 m_additionsSinceLastSweep = 0; 138 m_additionsSinceLastSweep = 0;
139 } 139 }
140 140
141 bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty le* style, const RenderStyle* parentStyle) 141 bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty le* style, const RenderStyle* parentStyle)
142 { 142 {
143 if (style->unique() || (style->styleType() != NOPSEUDO && parentStyle->uniqu e())) 143 if (style->unique() || (style->styleType() != NOPSEUDO && parentStyle->uniqu e()))
144 return false; 144 return false;
145 if (style->zoom() != RenderStyle::initialZoom()) 145 if (style->zoom() != RenderStyle::initialZoom())
146 return false; 146 return false;
147 if (style->writingMode() != RenderStyle::initialWritingMode())
148 return false;
149 if (style->hasCurrentColor()) 147 if (style->hasCurrentColor())
150 return false; 148 return false;
151 // The cache assumes static knowledge about which properties are inherited. 149 // The cache assumes static knowledge about which properties are inherited.
152 if (parentStyle->hasExplicitlyInheritedProperties()) 150 if (parentStyle->hasExplicitlyInheritedProperties())
153 return false; 151 return false;
154 return true; 152 return true;
155 } 153 }
156 154
157 void MatchedPropertiesCache::trace(Visitor* visitor) 155 void MatchedPropertiesCache::trace(Visitor* visitor)
158 { 156 {
159 } 157 }
160 158
161 } 159 }
OLDNEW
« no previous file with comments | « sky/engine/core/css/CSSProperty.cpp ('k') | sky/engine/core/css/resolver/StyleAdjuster.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698