Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: sky/engine/platform/LengthBox.h

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.cpp ('k') | sky/engine/platform/LengthBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 Copyright (C) 2006, 2008 Apple Inc. All rights reserved. 3 Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
4 Copyright (c) 2012, Google Inc. All rights reserved. 4 Copyright (c) 2012, Google Inc. All rights reserved.
5 5
6 This library is free software; you can redistribute it and/or 6 This library is free software; you can redistribute it and/or
7 modify it under the terms of the GNU Library General Public 7 modify it under the terms of the GNU Library General Public
8 License as published by the Free Software Foundation; either 8 License as published by the Free Software Foundation; either
9 version 2 of the License, or (at your option) any later version. 9 version 2 of the License, or (at your option) any later version.
10 10
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 , m_top(Length(t, Fixed)) 65 , m_top(Length(t, Fixed))
66 , m_bottom(Length(b, Fixed)) 66 , m_bottom(Length(b, Fixed))
67 { 67 {
68 } 68 }
69 69
70 const Length& left() const { return m_left; } 70 const Length& left() const { return m_left; }
71 const Length& right() const { return m_right; } 71 const Length& right() const { return m_right; }
72 const Length& top() const { return m_top; } 72 const Length& top() const { return m_top; }
73 const Length& bottom() const { return m_bottom; } 73 const Length& bottom() const { return m_bottom; }
74 74
75 const Length& logicalLeft(WritingMode) const; 75 const Length& logicalLeft() const;
76 const Length& logicalRight(WritingMode) const; 76 const Length& logicalRight() const;
77 77
78 const Length& before(WritingMode) const; 78 const Length& before() const;
79 const Length& after(WritingMode) const; 79 const Length& after() const;
80 const Length& start(WritingMode, TextDirection) const; 80 const Length& start(TextDirection) const;
81 const Length& end(WritingMode, TextDirection) const; 81 const Length& end(TextDirection) const;
82 82
83 bool operator==(const LengthBox& o) const 83 bool operator==(const LengthBox& o) const
84 { 84 {
85 return m_left == o.m_left && m_right == o.m_right && m_top == o.m_top && m_bottom == o.m_bottom; 85 return m_left == o.m_left && m_right == o.m_right && m_top == o.m_top && m_bottom == o.m_bottom;
86 } 86 }
87 87
88 bool operator!=(const LengthBox& o) const 88 bool operator!=(const LengthBox& o) const
89 { 89 {
90 return !(*this == o); 90 return !(*this == o);
91 } 91 }
92 92
93 bool nonZero() const 93 bool nonZero() const
94 { 94 {
95 return !(m_left.isZero() && m_right.isZero() && m_top.isZero() && m_bott om.isZero()); 95 return !(m_left.isZero() && m_right.isZero() && m_top.isZero() && m_bott om.isZero());
96 } 96 }
97 97
98 // Must be public for SET_VAR in RenderStyle.h 98 // Must be public for SET_VAR in RenderStyle.h
99 Length m_left; 99 Length m_left;
100 Length m_right; 100 Length m_right;
101 Length m_top; 101 Length m_top;
102 Length m_bottom; 102 Length m_bottom;
103 }; 103 };
104 104
105 } // namespace blink 105 } // namespace blink
106 106
107 #endif // LengthBox_h 107 #endif // LengthBox_h
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.cpp ('k') | sky/engine/platform/LengthBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698