sky/engine/core/rendering/style/RenderStyle.cpp - Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/style/RenderStyle.cpp

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/rendering/style/RenderStyle.cpp

diff --git a/sky/engine/core/rendering/style/RenderStyle.cpp b/sky/engine/core/rendering/style/RenderStyle.cpp

index 355f6bf5df84b81275810657b0b8ac054ee5a1ff..c9ae037d199242ec80b001046eb6b31ca4615720 100644

--- a/sky/engine/core/rendering/style/RenderStyle.cpp

+++ b/sky/engine/core/rendering/style/RenderStyle.cpp

@@ -414,8 +414,7 @@ bool RenderStyle::diffNeedsFullLayoutAndPaintInvalidation(const RenderStyle& oth

if (inherited_flags.m_rtlOrdering != other.inherited_flags.m_rtlOrdering

|| inherited_flags._text_align != other.inherited_flags._text_align

|| inherited_flags._direction != other.inherited_flags._direction

- || inherited_flags._white_space != other.inherited_flags._white_space

- || inherited_flags.m_writingMode != other.inherited_flags.m_writingMode)

+ || inherited_flags._white_space != other.inherited_flags._white_space)

return true;

if (noninherited_flags.overflowX != other.noninherited_flags.overflowX

« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.h ('k') | sky/engine/platform/LengthBox.h » ('j') | no next file with comments »