Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: sky/engine/core/css/CSSComputedStyleDeclaration.cpp

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 6 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public 9 * modify it under the terms of the GNU Lesser General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1445 matching lines...) Expand 10 before | Expand all | Expand 10 after
1456 style = computeRenderStyle(propertyID); 1456 style = computeRenderStyle(propertyID);
1457 renderer = m_node->renderer(); 1457 renderer = m_node->renderer();
1458 } 1458 }
1459 } else { 1459 } else {
1460 style = computeRenderStyle(propertyID); 1460 style = computeRenderStyle(propertyID);
1461 } 1461 }
1462 1462
1463 if (!style) 1463 if (!style)
1464 return nullptr; 1464 return nullptr;
1465 1465
1466 propertyID = CSSProperty::resolveDirectionAwareProperty(propertyID, style->d irection(), style->writingMode()); 1466 propertyID = CSSProperty::resolveDirectionAwareProperty(propertyID, style->d irection());
1467 1467
1468 switch (propertyID) { 1468 switch (propertyID) {
1469 case CSSPropertyInvalid: 1469 case CSSPropertyInvalid:
1470 break; 1470 break;
1471 1471
1472 case CSSPropertyBackgroundColor: 1472 case CSSPropertyBackgroundColor:
1473 return m_allowVisitedStyle ? cssValuePool().createColorValue(style-> colorIncludingFallback(CSSPropertyBackgroundColor).rgb()) : currentColorOrValidC olor(*style, style->backgroundColor()); 1473 return m_allowVisitedStyle ? cssValuePool().createColorValue(style-> colorIncludingFallback(CSSPropertyBackgroundColor).rgb()) : currentColorOrValidC olor(*style, style->backgroundColor());
1474 case CSSPropertyBackgroundImage: 1474 case CSSPropertyBackgroundImage:
1475 case CSSPropertyWebkitMaskImage: { 1475 case CSSPropertyWebkitMaskImage: {
1476 RefPtr<CSSValueList> list = CSSValueList::createCommaSeparated(); 1476 RefPtr<CSSValueList> list = CSSValueList::createCommaSeparated();
(...skipping 1273 matching lines...) Expand 10 before | Expand all | Expand 10 after
2750 return list.release(); 2750 return list.release();
2751 } 2751 }
2752 2752
2753 void CSSComputedStyleDeclaration::trace(Visitor* visitor) 2753 void CSSComputedStyleDeclaration::trace(Visitor* visitor)
2754 { 2754 {
2755 visitor->trace(m_node); 2755 visitor->trace(m_node);
2756 CSSStyleDeclaration::trace(visitor); 2756 CSSStyleDeclaration::trace(visitor);
2757 } 2757 }
2758 2758
2759 } // namespace blink 2759 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/build/scripts/templates/StyleBuilder.cpp.tmpl ('k') | sky/engine/core/css/CSSProperty.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698