Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: sky/engine/platform/geometry/LayoutBoxExtent.h

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/platform/LengthBox.cpp ('k') | sky/engine/platform/geometry/LayoutBoxExtent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012, Google Inc. All rights reserved. 2 * Copyright (c) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 inline LayoutUnit top() const { return m_top; } 47 inline LayoutUnit top() const { return m_top; }
48 inline LayoutUnit right() const { return m_right; } 48 inline LayoutUnit right() const { return m_right; }
49 inline LayoutUnit bottom() const { return m_bottom; } 49 inline LayoutUnit bottom() const { return m_bottom; }
50 inline LayoutUnit left() const { return m_left; } 50 inline LayoutUnit left() const { return m_left; }
51 51
52 inline void setTop(LayoutUnit value) { m_top = value; } 52 inline void setTop(LayoutUnit value) { m_top = value; }
53 inline void setRight(LayoutUnit value) { m_right = value; } 53 inline void setRight(LayoutUnit value) { m_right = value; }
54 inline void setBottom(LayoutUnit value) { m_bottom = value; } 54 inline void setBottom(LayoutUnit value) { m_bottom = value; }
55 inline void setLeft(LayoutUnit value) { m_left = value; } 55 inline void setLeft(LayoutUnit value) { m_left = value; }
56 56
57 LayoutUnit logicalTop(WritingMode) const; 57 LayoutUnit logicalTop() const;
58 LayoutUnit logicalBottom(WritingMode) const; 58 LayoutUnit logicalBottom() const;
59 LayoutUnit logicalLeft(WritingMode) const; 59 LayoutUnit logicalLeft() const;
60 LayoutUnit logicalRight(WritingMode) const; 60 LayoutUnit logicalRight() const;
61 61
62 LayoutUnit before(WritingMode) const; 62 LayoutUnit before() const;
63 LayoutUnit after(WritingMode) const; 63 LayoutUnit after() const;
64 LayoutUnit start(WritingMode, TextDirection) const; 64 LayoutUnit start(TextDirection) const;
65 LayoutUnit end(WritingMode, TextDirection) const; 65 LayoutUnit end(TextDirection) const;
66 66
67 void setBefore(WritingMode, LayoutUnit); 67 void setBefore(LayoutUnit);
68 void setAfter(WritingMode, LayoutUnit); 68 void setAfter(LayoutUnit);
69 void setStart(WritingMode, TextDirection, LayoutUnit); 69 void setStart(TextDirection, LayoutUnit);
70 void setEnd(WritingMode, TextDirection, LayoutUnit); 70 void setEnd(TextDirection, LayoutUnit);
71 71
72 LayoutUnit& mutableLogicalLeft(WritingMode); 72 LayoutUnit& mutableLogicalLeft();
73 LayoutUnit& mutableLogicalRight(WritingMode); 73 LayoutUnit& mutableLogicalRight();
74 74
75 LayoutUnit& mutableBefore(WritingMode); 75 LayoutUnit& mutableBefore();
76 LayoutUnit& mutableAfter(WritingMode); 76 LayoutUnit& mutableAfter();
77 77
78 private: 78 private:
79 LayoutUnit m_top; 79 LayoutUnit m_top;
80 LayoutUnit m_right; 80 LayoutUnit m_right;
81 LayoutUnit m_bottom; 81 LayoutUnit m_bottom;
82 LayoutUnit m_left; 82 LayoutUnit m_left;
83 }; 83 };
84 84
85 } // namespace blink 85 } // namespace blink
86 86
87 #endif // LayoutBoxExtent_h 87 #endif // LayoutBoxExtent_h
OLDNEW
« no previous file with comments | « sky/engine/platform/LengthBox.cpp ('k') | sky/engine/platform/geometry/LayoutBoxExtent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698