sky/engine/platform/LengthBox.h - Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/platform/LengthBox.h

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/platform/LengthBox.h

diff --git a/sky/engine/platform/LengthBox.h b/sky/engine/platform/LengthBox.h

index 74c45fb9da16598e2f1417aa1c81ed054d59f987..dd8a2cbb3222e009ee4cea08399682f636677717 100644

--- a/sky/engine/platform/LengthBox.h

+++ b/sky/engine/platform/LengthBox.h

@@ -72,13 +72,13 @@ public:

const Length& top() const { return m_top; }

const Length& bottom() const { return m_bottom; }

- const Length& logicalLeft(WritingMode) const;

- const Length& logicalRight(WritingMode) const;

+ const Length& logicalLeft() const;

+ const Length& logicalRight() const;

- const Length& before(WritingMode) const;

- const Length& after(WritingMode) const;

- const Length& start(WritingMode, TextDirection) const;

- const Length& end(WritingMode, TextDirection) const;

+ const Length& before() const;

+ const Length& after() const;

+ const Length& start(TextDirection) const;

+ const Length& end(TextDirection) const;

bool operator==(const LengthBox& o) const

{

« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.cpp ('k') | sky/engine/platform/LengthBox.cpp » ('j') | no next file with comments »