Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: sky/engine/platform/text/WritingMode.h

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/geometry/LayoutBoxExtent.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/text/WritingMode.h
diff --git a/sky/engine/platform/text/WritingMode.h b/sky/engine/platform/text/WritingMode.h
index 90716904cc152c55309a2c97da7965cd52801ff7..d607dac97eda6826fd8794c09f62492acb3d7c15 100644
--- a/sky/engine/platform/text/WritingMode.h
+++ b/sky/engine/platform/text/WritingMode.h
@@ -39,21 +39,21 @@ enum WritingMode {
};
// Lines have horizontal orientation; modes horizontal-tb or horizontal-bt.
-inline bool isHorizontalWritingMode(WritingMode writingMode)
+inline bool isHorizontalWritingMode()
{
// FIXME(sky): Remove
return true;
}
// Bottom of the line occurs earlier in the block; modes vertical-lr or horizontal-bt.
-inline bool isFlippedLinesWritingMode(WritingMode writingMode)
+inline bool isFlippedLinesWritingMode()
{
// FIXME(sky): Remove
return false;
}
// Block progression increases in the opposite direction to normal; modes vertical-rl or horizontal-bt.
-inline bool isFlippedBlocksWritingMode(WritingMode writingMode)
+inline bool isFlippedBlocksWritingMode()
{
// FIXME(sky): Remove
return false;
« no previous file with comments | « sky/engine/platform/geometry/LayoutBoxExtent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698