Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: sky/engine/core/rendering/InlineFlowBox.cpp

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Document.cpp ('k') | sky/engine/core/rendering/RenderBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/InlineFlowBox.cpp
diff --git a/sky/engine/core/rendering/InlineFlowBox.cpp b/sky/engine/core/rendering/InlineFlowBox.cpp
index 02e2137176f3d3207c9c1b0dac6e82f19b709df8..fb133ffea95c3a983c8b56e5e92d0ed9a56c4c3a 100644
--- a/sky/engine/core/rendering/InlineFlowBox.cpp
+++ b/sky/engine/core/rendering/InlineFlowBox.cpp
@@ -784,10 +784,10 @@ inline void InlineFlowBox::addBorderOutsetVisualOverflow(LayoutRect& logicalVisu
LayoutBoxExtent borderOutsets = style->borderImageOutsets();
- LayoutUnit borderOutsetLogicalTop = borderOutsets.logicalTop(style->writingMode());
- LayoutUnit borderOutsetLogicalBottom = borderOutsets.logicalBottom(style->writingMode());
- LayoutUnit borderOutsetLogicalLeft = borderOutsets.logicalLeft(style->writingMode());
- LayoutUnit borderOutsetLogicalRight = borderOutsets.logicalRight(style->writingMode());
+ LayoutUnit borderOutsetLogicalTop = borderOutsets.logicalTop();
+ LayoutUnit borderOutsetLogicalBottom = borderOutsets.logicalBottom();
+ LayoutUnit borderOutsetLogicalLeft = borderOutsets.logicalLeft();
+ LayoutUnit borderOutsetLogicalRight = borderOutsets.logicalRight();
// Similar to how glyph overflow works, if our lines are flipped, then it's actually the opposite border that applies, since
// the line is "upside down" in terms of block coordinates. vertical-rl and horizontal-bt are the flipped line modes.
« no previous file with comments | « sky/engine/core/dom/Document.cpp ('k') | sky/engine/core/rendering/RenderBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698